Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issue 450103005: Add inherited flag to CSSProperties.in (Closed)

Created:
6 years, 4 months ago by Timothy Loh
Modified:
6 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add inherited flag to CSSProperties.in This patch adds the flag 'inherited' to CSSProperties.in, replacing the existing switch statement in CSSProperty.cpp. The primary use for isInheritedProperty appears to be as part of the MatchedPropertiesCache optimisation. I've added the inherited flag to overflow-wrap and paint-order, which are inherited in the code and specs[1][2] but were not returning true in the switch. As far as I can tell, this has no difference aside from making us still use the MatchedPropertiesCache if these are explicitly set to inherit. I also added a fixme indicating that the property resize shouldn't inherit by default. [1] http://dev.w3.org/csswg/css-text/#overflow-wrap-property [2] https://svgwg.org/svg2-draft/painting.html#PaintOrder BUG=396992 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180051 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180216

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : mark paint-order inherited #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -519 lines) Patch
M Source/build/scripts/css_properties.py View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/build/scripts/make_css_property_metadata.py View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 3 13 chunks +99 lines, -95 lines 0 comments Download
M Source/core/css/CSSProperty.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +0 lines, -415 lines 0 comments Download
M Source/core/css/CSSPropertyMetadata.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Timothy Loh
(depends on https://codereview.chromium.org/454423003/ landing first)
6 years, 4 months ago (2014-08-12 04:00:38 UTC) #1
alancutter (OOO until 2018)
lgtm Reviewed in person.
6 years, 4 months ago (2014-08-12 04:16:17 UTC) #2
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-12 07:30:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/450103005/40001
6 years, 4 months ago (2014-08-12 07:30:45 UTC) #4
Erik Dahlström (inactive)
https://codereview.chromium.org/450103005/diff/40001/Source/core/css/CSSProperties.in File Source/core/css/CSSProperties.in (left): https://codereview.chromium.org/450103005/diff/40001/Source/core/css/CSSProperties.in#oldcode227 Source/core/css/CSSProperties.in:227: paint-order svg, converter=convertPaintOrder paint-order should be marked as inherited, ...
6 years, 4 months ago (2014-08-12 07:55:44 UTC) #5
Timothy Loh
https://codereview.chromium.org/450103005/diff/40001/Source/core/css/CSSProperties.in File Source/core/css/CSSProperties.in (left): https://codereview.chromium.org/450103005/diff/40001/Source/core/css/CSSProperties.in#oldcode227 Source/core/css/CSSProperties.in:227: paint-order svg, converter=convertPaintOrder On 2014/08/12 07:55:44, Erik Dahlström wrote: ...
6 years, 4 months ago (2014-08-12 08:12:12 UTC) #6
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-12 08:12:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/450103005/60001
6 years, 4 months ago (2014-08-12 08:12:58 UTC) #8
commit-bot: I haz the power
Change committed as 180051
6 years, 4 months ago (2014-08-12 09:25:03 UTC) #9
adamk
Reverted in https://src.chromium.org/viewvc/blink?revision=180090&view=revision for assertion failures in print preview browser_tests
6 years, 4 months ago (2014-08-12 18:17:23 UTC) #10
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-14 00:12:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/450103005/60001
6 years, 4 months ago (2014-08-14 00:13:08 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 00:14:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (60001) as 180216

Powered by Google App Engine
This is Rietveld 408576698