Source/core/animation/css/CSSAnimatableValueFactory.cpp - Issue 462133002: Remove custom style building functions for 'clip'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 462133002: Remove custom style building functions for 'clip'. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/css/CSSAnimatableValueFactory.cpp

diff --git a/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/Source/core/animation/css/CSSAnimatableValueFactory.cpp

index bf953edf0830c611e9c09ff53724944af1789765..0379bc37c64adbf88566967047452900d066fee5 100644

--- a/Source/core/animation/css/CSSAnimatableValueFactory.cpp

+++ b/Source/core/animation/css/CSSAnimatableValueFactory.cpp

@@ -323,9 +323,9 @@ PassRefPtrWillBeRawPtr<AnimatableValue> CSSAnimatableValueFactory::create(CSSPro

case CSSPropertyWebkitBoxShadow:

return AnimatableShadow::create(style.boxShadow());

case CSSPropertyClip:

- if (style.hasClip())

- return createFromLengthBox(style.clip(), style);

- return AnimatableUnknown::create(CSSPrimitiveValue::create(CSSValueAuto));

+ if (style.hasAutoClip())

+ return AnimatableUnknown::create(CSSPrimitiveValue::create(CSSValueAuto));

+ return createFromLengthBox(style.clip(), style);

case CSSPropertyColor:

return createFromColor(property, style);

case CSSPropertyFillOpacity:

« no previous file with comments | « Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »