chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/translate/cld_data_harness_factory.cc ('K') | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc » ('j') | components/translate/content/browser/browser_cld_data_provider_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

index 15dffcc909d092b0ed434dd2ecefdc5de026b1de..95b871b194d2bb838074c45813a291ef05a3794e 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

@@ -8,6 +8,7 @@

#include "base/memory/scoped_ptr.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/translate/cld_data_harness.h"

+#include "chrome/browser/translate/cld_data_harness_factory.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/browser_tabstrip.h"

@@ -21,7 +22,8 @@

class TranslateBubbleViewBrowserTest : public InProcessBrowserTest {

public:

TranslateBubbleViewBrowserTest()

- : cld_data_harness(test::CreateCldDataHarness()) {}

+ : cld_data_harness(

+ test::CldDataHarnessFactory::Get()->CreateCldDataHarness()) {}

virtual ~TranslateBubbleViewBrowserTest() {}

virtual void SetUpOnMainThread() OVERRIDE {

// We can't Init() until PathService has been initialized. This happens