chrome/browser/ui/browser_browsertest.cc - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/translate/cld_data_harness_factory.cc ('K') | « chrome/browser/translate/translate_manager_browsertest.cc ('k') | chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc » ('j') | components/translate/content/browser/browser_cld_data_provider_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index c86c59bdfcbdc0aad373ab85e5d57f215bf4a4b1..e776bacf98c0e8f446db4c763e38d69ba5cb4c58 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -32,6 +32,7 @@

#include "chrome/browser/sessions/session_service_factory.h"

#include "chrome/browser/translate/chrome_translate_client.h"

#include "chrome/browser/translate/cld_data_harness.h"

+#include "chrome/browser/translate/cld_data_harness_factory.h"

#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h"

#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h"

#include "chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h"

@@ -1408,7 +1409,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ShouldShowLocationBar) {

// Tests that the CLD (Compact Language Detection) works properly.

IN_PROC_BROWSER_TEST_F(BrowserTest, PageLanguageDetection) {

scoped_ptr<test::CldDataHarness> cld_data_harness =

- test::CreateCldDataHarness();

+ test::CldDataHarnessFactory::Get()->CreateCldDataHarness();

ASSERT_NO_FATAL_FAILURE(cld_data_harness->Init());

ASSERT_TRUE(test_server()->Start());