chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/translate/cld_data_harness_factory.cc ('K') | « chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc ('k') | chrome/chrome_renderer.gypi » ('j') | components/translate/content/browser/browser_cld_data_provider_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc b/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

index 12dabaa4db16c6cc2a7463a99f77704b2875ed74..e8c0e6870f8845322cacaa34a8cf7765f5b20a5a 100644

--- a/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

@@ -70,7 +70,7 @@ content::WebUIDataSource* CreateTranslateInternalsHTMLSource() {

cld_data_source = "static"; // CLD1.x does not support dynamic data loading

#elif CLD_VERSION==2

cld_version = "2";

- cld_data_source = translate::CldDataSource::GetName();

+ cld_data_source = translate::CldDataSource::Get()->GetName();

#else

NOTREACHED();

#endif