Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 461373002: Oilpan: make r180096's FIXME comment accurate. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: make r180096's FIXME comment accurate. The underlying cause described in r180096 wasn't correct; update the FIXME comment to make it more accurate. R=haraken BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-13 06:23:27 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-13 06:50:29 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-13 06:51:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/461373002/1
6 years, 4 months ago (2014-08-13 06:52:11 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 06:52:43 UTC) #5
Message was sent while issue was closed.
Change committed as 180147

Powered by Google App Engine
This is Rietveld 408576698