Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 461373002: Oilpan: make r180096's FIXME comment accurate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
index 80ed8c49cdd5bf98a1924f561d4154d03d178987..cc6899f7753ee224362de8fb75f809bde47b1e54 100644
--- a/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
@@ -55,12 +55,14 @@ static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, Atomic
// FIXME: HTML5 specification says this should be a HTMLCollection.
// http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection
//
- // FIXME: Oilpan: explicit conversion needed as there is currently
- // no implicit RawPtr<T>(RawPtr<U>) constructor (for type
- // convertible pairs T and U) that would implicitly convert a
- // RawPtr<StaticElementList> to a RawPtr<NodeList> (the former is
- // a subclass of the latter.) Such a conversion is needed to
- // resolve the toV8() call.
+ // FIXME: Oilpan: explicitly convert adopt()'s result so as to
+ // disambiguate the (implicit) conversion of its
+ // PassRefPtrWillBeRawPtr<StaticElementList> result -- the
+ // other toV8() overload that introduces the ambiguity is
+ // toV8(NodeList*, ...).
+ //
+ // When adopt() no longer uses transition types, the conversion
+ // can be removed.
return toV8(PassRefPtrWillBeRawPtr<NodeList>(StaticElementList::adopt(namedItems)), info.Holder(), info.GetIsolate());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698