Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 461373002: Oilpan: make r180096's FIXME comment accurate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 if (!namedItems.size()) 49 if (!namedItems.size())
50 return v8Undefined(); 50 return v8Undefined();
51 51
52 if (namedItems.size() == 1) 52 if (namedItems.size() == 1)
53 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() ); 53 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() );
54 54
55 // FIXME: HTML5 specification says this should be a HTMLCollection. 55 // FIXME: HTML5 specification says this should be a HTMLCollection.
56 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection 56 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection
57 // 57 //
58 // FIXME: Oilpan: explicit conversion needed as there is currently 58 // FIXME: Oilpan: explicitly convert adopt()'s result so as to
59 // no implicit RawPtr<T>(RawPtr<U>) constructor (for type 59 // disambiguate the (implicit) conversion of its
60 // convertible pairs T and U) that would implicitly convert a 60 // PassRefPtrWillBeRawPtr<StaticElementList> result -- the
61 // RawPtr<StaticElementList> to a RawPtr<NodeList> (the former is 61 // other toV8() overload that introduces the ambiguity is
62 // a subclass of the latter.) Such a conversion is needed to 62 // toV8(NodeList*, ...).
63 // resolve the toV8() call. 63 //
64 // When adopt() no longer uses transition types, the conversion
65 // can be removed.
64 return toV8(PassRefPtrWillBeRawPtr<NodeList>(StaticElementList::adopt(namedI tems)), info.Holder(), info.GetIsolate()); 66 return toV8(PassRefPtrWillBeRawPtr<NodeList>(StaticElementList::adopt(namedI tems)), info.Holder(), info.GetIsolate());
65 } 67 }
66 68
67 template<class CallbackInfo> 69 template<class CallbackInfo>
68 static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v 8::Value> argument, const CallbackInfo& info) 70 static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v 8::Value> argument, const CallbackInfo& info)
69 { 71 {
70 v8::Local<v8::Uint32> index = argument->ToArrayIndex(); 72 v8::Local<v8::Uint32> index = argument->ToArrayIndex();
71 if (index.IsEmpty()) { 73 if (index.IsEmpty()) {
72 TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info. GetIsolate())); 74 TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info. GetIsolate()));
73 v8::Handle<v8::Value> result = getNamedItems(collection, name, info); 75 v8::Handle<v8::Value> result = getNamedItems(collection, name, info);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 if (index.IsEmpty()) 111 if (index.IsEmpty())
110 return; 112 return;
111 113
112 if (Node* node = impl->namedItemWithIndex(name, index->Uint32Value())) { 114 if (Node* node = impl->namedItemWithIndex(name, index->Uint32Value())) {
113 v8SetReturnValueFast(info, node, impl); 115 v8SetReturnValueFast(info, node, impl);
114 return; 116 return;
115 } 117 }
116 } 118 }
117 119
118 } // namespace blink 120 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698