chrome/browser/ui/ash/app_list/app_list_controller_ash.cc - Issue 460933002: Split Shell::ToggleAppList() into ShowAppList and DismissAppList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

Issue 460933002: Split Shell::ToggleAppList() into ShowAppList and DismissAppList. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

diff --git a/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc b/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

index 1b642faddfab0d796c048518f7a48902a6ef7187..857e41da66dd367bd8cbc89a1061429db5a01ca7 100644

--- a/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

+++ b/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

@@ -15,8 +15,7 @@ AppListControllerDelegateAsh::~AppListControllerDelegateAsh() {}

void AppListControllerDelegateAsh::DismissView() {

DCHECK(ash::Shell::HasInstance());

- if (ash::Shell::GetInstance()->GetAppListTargetVisibility())

- ash::Shell::GetInstance()->ToggleAppList(NULL);

+ ash::Shell::GetInstance()->DismissAppList();

}

gfx::NativeWindow AppListControllerDelegateAsh::GetAppListWindow() {