Split Shell::ToggleAppList() into ShowAppList and DismissAppList.

ash/shell.h

Index: ash/shell.h
diff --git a/ash/shell.h b/ash/shell.h
index 14e1f9144cdffef725d80b85ce2509ac741efe46..7d5ab3b680ae1f725e3e66a424752d5bc5b55a7f 100644
--- a/ash/shell.h
+++ b/ash/shell.h
@@ -231,9 +231,15 @@ class ASH_EXPORT Shell : public SystemModalContainerEventFilterDelegate,
   void ShowContextMenu(const gfx::Point& location_in_screen,
                        ui::MenuSourceType source_type);
 
-  // Toggles the app list. |window| specifies in which display the app
+  // Shows the app list. |window| specifies in which display the app
   // list should be shown. If this is NULL, the active root window
   // will be used.
+  void ShowAppList(aura::Window* anchor);

[James Cook, 2014/08/14 20:49:36]

Another option would be to provide "SetAppListVisible(bool visible,
aura::Window* anchor, Reason reason)" instead of these three methods.

The Shell API surface is already huge and that would keep things a bit smaller.

[Matt Giuca, 2014/08/15 01:00:21]

I have a slight preference to keep things the way they are (I think the current
3 methods provide a nice simple interface for a few dozen call sites; having
just 1 method makes all the call sites slightly more complex).

But I wouldn't mind if you change this.

+
+  // Dismisses the app list.
+  void DismissAppList();
+
+  // Shows the app list if it's not visible. Dismisses it otherwise.
   void ToggleAppList(aura::Window* anchor);
 
   // Returns app list target visibility.