ash/wm/window_cycle_controller_unittest.cc - Issue 460933002: Split Shell::ToggleAppList() into ShowAppList and DismissAppList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/window_cycle_controller_unittest.cc

Issue 460933002: Split Shell::ToggleAppList() into ShowAppList and DismissAppList. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/window_cycle_controller_unittest.cc

diff --git a/ash/wm/window_cycle_controller_unittest.cc b/ash/wm/window_cycle_controller_unittest.cc

index 8680472ffcc2cef516e15a9d1f147dc65a3224de..06cc61ee5c92e0da627ddf93ed07dc3e7454d0be 100644

--- a/ash/wm/window_cycle_controller_unittest.cc

+++ b/ash/wm/window_cycle_controller_unittest.cc

@@ -469,7 +469,7 @@ TEST_F(WindowCycleControllerTest, SelectingHidesAppList) {

scoped_ptr<aura::Window> window0(CreateTestWindowInShellWithId(0));

scoped_ptr<aura::Window> window1(CreateTestWindowInShellWithId(1));

- Shell::GetInstance()->ToggleAppList(NULL);

+ Shell::GetInstance()->ShowAppList(NULL);

EXPECT_TRUE(Shell::GetInstance()->GetAppListTargetVisibility());

controller->HandleCycleWindow(WindowCycleController::FORWARD);

EXPECT_FALSE(Shell::GetInstance()->GetAppListTargetVisibility());