Remove the last piece of deprecated synchronous IO code.

Remove the last piece of deprecated synchronous IO code.

BUG=337096
TEST=bots

Committed: https://crrev.com/2da7a5b3ead29495a3d2640343ab18c93e2805b5
Cr-Commit-Position: refs/heads/master@{#292132}

[xians, 2014-08-12 13:12:35]

Dale, please review this CL.

Andrew, would you please take a look at my question?


Thanks,
SX

https://codereview.chromium.org/460373002/diff/1/media/audio/audio_parameters.h
File media/audio/audio_parameters.h (right):

https://codereview.chromium.org/460373002/diff/1/media/audio/audio_parameters...
media/audio/audio_parameters.h:63: AudioParameters(Format format, ChannelLayout
channel_layout,
Andrew, you added this constructor in https://codereview.chromium.org/115413002,
but I don't see any use case in our code, do you mind telling me why it is
desired? I would like to remove it if it is not needed?

[DaleCurtis, 2014-08-12 17:05:18]

Needed a quick vacation from paternity leave? :)

lgtm if it passes the bots. I suspect there may be some NaCl / PPAPI pieces
you're missing here though.

[no longer working on chromium, 2014-08-12 19:09:36]

On 2014/08/12 17:05:18, DaleCurtis wrote:
> Needed a quick vacation from paternity leave? :)
> 


Yes, I might take some days off soon :)


> lgtm if it passes the bots. I suspect there may be some NaCl / PPAPI pieces
> you're missing here though.


Thanks. I will make sure it passes all the bots.

[no longer working on chromium, 2014-08-12 19:10:22]

Andrew, could you please take a look at my question?

Thanks,
SX

[ajm, 2014-08-13 00:40:41]

https://codereview.chromium.org/460373002/diff/1/media/audio/audio_parameters.h
File media/audio/audio_parameters.h (right):

https://codereview.chromium.org/460373002/diff/1/media/audio/audio_parameters...
media/audio/audio_parameters.h:63: AudioParameters(Format format, ChannelLayout
channel_layout,
On 2014/08/12 13:12:35, xians wrote:
> Andrew, you added this constructor in
https://codereview.chromium.org/115413002,
> but I don't see any use case in our code, do you mind telling me why it is
> desired? I would like to remove it if it is not needed?

I'm guessing the code that used it was since removed. If it's really not used,
feel free to remove it.

[no longer working on chromium, 2014-08-13 15:24:58]

https://codereview.chromium.org/460373002/diff/1/media/audio/audio_parameters.h
File media/audio/audio_parameters.h (right):

https://codereview.chromium.org/460373002/diff/1/media/audio/audio_parameters...
media/audio/audio_parameters.h:63: AudioParameters(Format format, ChannelLayout
channel_layout,
On 2014/08/13 00:40:41, ajm wrote:
> On 2014/08/12 13:12:35, xians wrote:
> > Andrew, you added this constructor in
> https://codereview.chromium.org/115413002,
> > but I don't see any use case in our code, do you mind telling me why it is
> > desired? I would like to remove it if it is not needed?
> 
> I'm guessing the code that used it was since removed. If it's really not used,
> feel free to remove it.

Thanks Andrew, it turns out that the code is used by some unittest and
audio_manager_mac.cc, I have to keep it for now.

[no longer working on chromium, 2014-08-13 15:25:02]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-08-13 15:26:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/460373002/40001

[commit-bot: I haz the power, 2014-08-13 16:12:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/41183)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/46395)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-13 16:15:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 16:15:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[no longer working on chromium, 2014-08-19 13:39:01]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-08-19 13:40:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/460373002/80001

[commit-bot: I haz the power, 2014-08-19 15:02:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-19 15:05:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-19 15:05:56]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[no longer working on chromium, 2014-08-19 16:38:24]

avi, can I have your owner stamp for content/common and content/renderer/
Rahul, please look at components/copresence/mediums.

Thanks,
SX

[Avi (use Gerrit), 2014-08-19 16:45:53]

On 2014/08/19 16:38:24, xians1 wrote:
> avi, can I have your owner stamp for content/common and content/renderer/
> Rahul, please look at components/copresence/mediums.
> 
> Thanks,
> SX

In the issue description:
s/synchronize/synchronous/

Let me look at the source files.

[no longer working on chromium, 2014-08-19 16:47:20]

On 2014/08/19 16:45:53, Avi wrote:
> On 2014/08/19 16:38:24, xians1 wrote:
> > avi, can I have your owner stamp for content/common and content/renderer/
> > Rahul, please look at components/copresence/mediums.
> > 
> > Thanks,
> > SX
> 
> In the issue description:
> s/synchronize/synchronous/
> 
> Let me look at the source files.

Thanks, done.

[Avi (use Gerrit), 2014-08-19 16:47:41]

All of content/ LGTM

[Avi (use Gerrit), 2014-08-19 16:48:16]

On 2014/08/19 16:47:41, Avi wrote:
> All of content/ LGTM

BTW, content/common/media/media_param_traits.cc is IPC so you will need a
reviewer for that file.

[no longer working on chromium, 2014-08-19 18:33:36]

On 2014/08/19 16:48:16, Avi wrote:
> On 2014/08/19 16:47:41, Avi wrote:
> > All of content/ LGTM
> 

Thanks Avi.

> BTW, content/common/media/media_param_traits.cc is IPC so you will need a
> reviewer for that file.

dalecurtis seems to be a owner of content/common/media, so I guess the change
there is fine.

[Avi (use Gerrit), 2014-08-19 19:51:05]

On 2014/08/19 18:33:36, xians1 wrote:
> On 2014/08/19 16:48:16, Avi wrote:
> > On 2014/08/19 16:47:41, Avi wrote:
> > > All of content/ LGTM
> > 
> 
> Thanks Avi.
> 
> > BTW, content/common/media/media_param_traits.cc is IPC so you will need a
> > reviewer for that file.
> 
> dalecurtis seems to be a owner of content/common/media, so I guess the change
> there is fine.

No it is not.

IPC files are special. Look at content/common/media/OWNERS. That file is SPECIAL
because it is IPC and you need a security review.

[rkc, 2014-08-25 21:16:41]

copresence/* lgtm
Much nicer. I was wondering why we need to specify the channels after we give
the channel layout already :)

[no longer working on chromium, 2014-08-26 07:51:41]

xians@chromium.org changed reviewers:
+ palmer@chromium.org

[no longer working on chromium, 2014-08-26 07:51:41]

palmer, could you please take a look at
content/common/media/media_param_traits.cc? 

Thanks,
SX

[no longer working on chromium, 2014-08-26 07:52:41]

On 2014/08/19 19:51:05, Avi wrote:
> On 2014/08/19 18:33:36, xians1 wrote:
> > On 2014/08/19 16:48:16, Avi wrote:
> > > On 2014/08/19 16:47:41, Avi wrote:
> > > > All of content/ LGTM
> > > 
> > 
> > Thanks Avi.
> > 
> > > BTW, content/common/media/media_param_traits.cc is IPC so you will need a
> > > reviewer for that file.
> > 
> > dalecurtis seems to be a owner of content/common/media, so I guess the
change
> > there is fine.
> 
> No it is not.
> 
> IPC files are special. Look at content/common/media/OWNERS. That file is
SPECIAL
> because it is IPC and you need a security review.

Thanks, I am asking palmer to take a look then.

[palmer, 2014-08-26 20:20:29]

Rubberstamp LGTM

[no longer working on chromium, 2014-08-27 09:26:38]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-08-27 09:26:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/460373002/80001

[commit-bot: I haz the power, 2014-08-27 10:21:48]

Committed patchset #5 (80001) as c4a64ffdd0d511c66d774341fa0a318af7911193

[Thiemo Nagel, 2014-08-27 11:00:34]

A revert of this CL (patchset #5) has been created in
https://codereview.chromium.org/509893002/ by tnagel@chromium.org.

The reason for reverting is: Build failure on Google Chrome ChromeOS:

http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chro....

[rkc, 2014-08-27 21:36:51]

You should be able to land this CL now.
https://codereview.chromium.org/510893003/ removed the ledger code from Chrome.

[no longer working on chromium, 2014-08-28 18:12:30]

On 2014/08/27 21:36:51, Rahul Chaturvedi wrote:
> You should be able to land this CL now.
> https://codereview.chromium.org/510893003/ removed the ledger code from
Chrome.


Thanks Rahul, then I am going to reland the CL by reverting the revert.

[no longer working on chromium, 2014-09-01 09:57:57]

xians@chromium.org changed reviewers:
+ tommi@chromium.org

[no longer working on chromium, 2014-09-01 09:57:58]

Tommi, FYI, this is the original CL, and the reland one is
https://codereview.chromium.org/518433002/

[commit-bot: I haz the power, 2014-09-10 02:51:02]

Patchset 5 (id:??) landed as
https://crrev.com/2da7a5b3ead29495a3d2640343ab18c93e2805b5
Cr-Commit-Position: refs/heads/master@{#292132}