Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 45973006: Require DOMWrapperWorld in event handler macros (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, jsbell, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, dgrogan, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@globaleventhandlers
Visibility:
Public.

Description

Require DOMWrapperWorld in event handler macros BUG=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : use DOMWrapperWorld::current() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/events/EventTarget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
haraken, this was the consequence of dropping the "= 0" where you pointed. I have ...
7 years, 1 month ago (2013-10-26 20:31:49 UTC) #1
haraken
Thanks philipj. > setAttributeEventListener and getAttributeEventListener in this file also make > DOMWrapperWorld optional, should ...
7 years, 1 month ago (2013-10-27 02:11:57 UTC) #2
haraken
https://codereview.chromium.org/45973006/diff/1/Source/core/inspector/InspectorFileSystemAgent.cpp File Source/core/inspector/InspectorFileSystemAgent.cpp (right): https://codereview.chromium.org/45973006/diff/1/Source/core/inspector/InspectorFileSystemAgent.cpp#newcode475 Source/core/inspector/InspectorFileSystemAgent.cpp:475: m_reader->setOnload(this, 0); You could use MainWorldId instead of 0.
7 years, 1 month ago (2013-10-27 02:12:04 UTC) #3
philipj_slow
On 2013/10/27 02:11:57, haraken wrote: > Thanks philipj. > > > setAttributeEventListener and getAttributeEventListener in ...
7 years, 1 month ago (2013-10-27 08:18:53 UTC) #4
philipj_slow
On 2013/10/27 02:11:57, haraken wrote: > Thanks philipj. > > > setAttributeEventListener and getAttributeEventListener in ...
7 years, 1 month ago (2013-10-27 08:22:21 UTC) #5
haraken
> |isolatedWorld| is a DOMWrapperWorld*, which has an integer |m_worldId|, but as > far as ...
7 years, 1 month ago (2013-10-27 12:05:25 UTC) #6
philipj_slow
On 2013/10/27 12:05:25, haraken wrote: > > |isolatedWorld| is a DOMWrapperWorld*, which has an integer ...
7 years, 1 month ago (2013-10-27 20:58:44 UTC) #7
haraken
> What (potential) bug would this fix, and is the difference testable in LayoutTests? In ...
7 years, 1 month ago (2013-10-28 00:27:47 UTC) #8
alecflett
On 2013/10/28 00:27:47, haraken wrote: > > What (potential) bug would this fix, and is ...
7 years, 1 month ago (2013-10-28 20:29:54 UTC) #9
philipj_slow
Sorry for letting this sit for so long, but I don't really know what to ...
7 years, 1 month ago (2013-11-04 08:00:54 UTC) #10
philipj_slow
7 years, 1 month ago (2013-11-13 14:44:04 UTC) #11
Since this has been sitting with no progress for over a week I am going to close
and abandon it now. Maybe someone with a better understanding of the root
problem can pick this up, if it seems important.

Powered by Google App Engine
This is Rietveld 408576698