Source/core/events/EventTarget.h - Issue 45973006: Require DOMWrapperWorld in event handler macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/EventTarget.h

Issue 45973006: Require DOMWrapperWorld in event handler macros (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@globaleventhandlers

Patch Set: use DOMWrapperWorld::current() Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: Source/core/events/EventTarget.h

diff --git a/Source/core/events/EventTarget.h b/Source/core/events/EventTarget.h

index 6889bfc87ccb368b4d4de04c253683215d84b458..8d5200a779d7bc454f6d9123fb8ea49e7ce099f0 100644

--- a/Source/core/events/EventTarget.h

+++ b/Source/core/events/EventTarget.h

@@ -160,11 +160,11 @@ private:

// macros to avoid causing so many header includes.

#define DEFINE_ATTRIBUTE_EVENT_LISTENER(attribute) \

EventListener* on##attribute(DOMWrapperWorld* isolatedWorld) { return getAttributeEventListener(EventTypeNames::attribute, isolatedWorld); } \

- void setOn##attribute(PassRefPtr<EventListener> listener, DOMWrapperWorld* isolatedWorld = 0) { setAttributeEventListener(EventTypeNames::attribute, listener, isolatedWorld); } \

+ void setOn##attribute(PassRefPtr<EventListener> listener, DOMWrapperWorld* isolatedWorld) { setAttributeEventListener(EventTypeNames::attribute, listener, isolatedWorld); } \

#define DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(attribute) \

static EventListener* on##attribute(EventTarget* eventTarget, DOMWrapperWorld* isolatedWorld) { return eventTarget->getAttributeEventListener(EventTypeNames::attribute, isolatedWorld); } \

- static void setOn##attribute(EventTarget* eventTarget, PassRefPtr<EventListener> listener, DOMWrapperWorld* isolatedWorld = 0) { eventTarget->setAttributeEventListener(EventTypeNames::attribute, listener, isolatedWorld); } \

+ static void setOn##attribute(EventTarget* eventTarget, PassRefPtr<EventListener> listener, DOMWrapperWorld* isolatedWorld) { eventTarget->setAttributeEventListener(EventTypeNames::attribute, listener, isolatedWorld); } \

#define DEFINE_WINDOW_ATTRIBUTE_EVENT_LISTENER(attribute) \

EventListener* on##attribute(DOMWrapperWorld* isolatedWorld) { return document().getWindowAttributeEventListener(EventTypeNames::attribute, isolatedWorld); } \

« no previous file with comments | « no previous file | Source/core/inspector/InspectorFileSystemAgent.cpp » ('j') | no next file with comments »