Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 458663003: getElementsByClassName should include non styled Elements (Closed)

Created:
6 years, 4 months ago by rwlbuis
Modified:
6 years, 4 months ago
Reviewers:
eae, Inactive
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

getElementsByClassName should include non styled Elements Allow Elements who are not styled but have class set to be retrieved using getElementsByClassName. Matches FF behavior. https://bugs.webkit.org/show_bug.cgi?id=94718 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180414

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Add test #

Total comments: 1

Patch Set 4 : Use use js-test.js #

Total comments: 4

Patch Set 5 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M LayoutTests/fast/dom/getElementsByClassName/011.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/getElementsByClassName/non-styled-elements-expected.txt View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/dom/ClassCollection.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
rwlbuis
PTAL.
6 years, 4 months ago (2014-08-12 19:53:59 UTC) #1
eae
Could you please add a dedicated test for this?
6 years, 4 months ago (2014-08-12 22:07:05 UTC) #2
Inactive
What's IE's behavior?
6 years, 4 months ago (2014-08-13 00:35:57 UTC) #3
Inactive
Also, I would add an API owner as reviewer since this is a Web-exposed change ...
6 years, 4 months ago (2014-08-13 00:38:00 UTC) #4
rwlbuis
On 2014/08/13 00:35:57, Chris Dumez wrote: > What's IE's behavior? IE11 has the old behavior ...
6 years, 4 months ago (2014-08-13 16:47:24 UTC) #5
rwlbuis
On 2014/08/13 00:38:00, Chris Dumez wrote: > Also, I would add an API owner as ...
6 years, 4 months ago (2014-08-13 16:48:17 UTC) #6
rwlbuis
On 2014/08/12 22:07:05, eae wrote: > Could you please add a dedicated test for this? ...
6 years, 4 months ago (2014-08-13 16:48:29 UTC) #7
Inactive
https://codereview.chromium.org/458663003/diff/60001/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.xml File LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.xml (right): https://codereview.chromium.org/458663003/diff/60001/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.xml#newcode7 LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.xml:7: if (window.testRunner) Could you use js-test.js?
6 years, 4 months ago (2014-08-15 18:38:57 UTC) #8
rwlbuis
On 2014/08/15 18:38:57, Chris Dumez wrote: > https://codereview.chromium.org/458663003/diff/60001/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.xml > File LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.xml > (right): > > ...
6 years, 4 months ago (2014-08-15 22:06:02 UTC) #9
eae
Having the script for the test in a separate file is the old (deprecated) way ...
6 years, 4 months ago (2014-08-15 22:08:55 UTC) #10
Inactive
https://codereview.chromium.org/458663003/diff/80001/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html File LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html (right): https://codereview.chromium.org/458663003/diff/80001/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html#newcode1 LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html:1: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> <!DOCTYPE html> ? https://codereview.chromium.org/458663003/diff/80001/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html#newcode7 ...
6 years, 4 months ago (2014-08-16 17:17:10 UTC) #11
rwlbuis
On 2014/08/16 17:17:10, Chris Dumez wrote: > https://codereview.chromium.org/458663003/diff/80001/LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html > File LayoutTests/fast/dom/getElementsByClassName/non-styled-elements.html > (right): > > ...
6 years, 4 months ago (2014-08-16 22:19:58 UTC) #12
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 4 months ago (2014-08-16 22:31:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/458663003/100001
6 years, 4 months ago (2014-08-16 22:31:44 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-16 23:37:53 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-16 23:48:53 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23079)
6 years, 4 months ago (2014-08-16 23:48:54 UTC) #17
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 4 months ago (2014-08-17 00:18:43 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/458663003/100001
6 years, 4 months ago (2014-08-17 00:19:00 UTC) #19
commit-bot: I haz the power
6 years, 4 months ago (2014-08-17 00:47:05 UTC) #20
Message was sent while issue was closed. 
Committed patchset #5 (100001) as 180414

Powered by Google App Engine
This is Rietveld 408576698