Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: Source/core/dom/ClassCollection.h

Issue 458663003: getElementsByClassName should include non styled Elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/dom/getElementsByClassName/non-styled-elements-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ClassCollection.h
diff --git a/Source/core/dom/ClassCollection.h b/Source/core/dom/ClassCollection.h
index 290e70bd0d923ab4efbc12fdf11f8cd618358668..36c693aae34acc4c3cc745f03501da09b3c77472 100644
--- a/Source/core/dom/ClassCollection.h
+++ b/Source/core/dom/ClassCollection.h
@@ -65,10 +65,6 @@ inline bool ClassCollection::elementMatches(const Element& testElement) const
return false;
if (!m_classNames.size())
return false;
- // FIXME: DOM4 allows getElementsByClassName to return non StyledElement.
- // https://bugs.webkit.org/show_bug.cgi?id=94718
- if (!testElement.isStyledElement())
- return false;
return testElement.classNames().containsAll(m_classNames);
}
« no previous file with comments | « LayoutTests/fast/dom/getElementsByClassName/non-styled-elements-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698