Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: Source/core/dom/ClassCollection.h

Issue 458663003: getElementsByClassName should include non styled Elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/dom/getElementsByClassName/non-styled-elements-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com) 3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 }; 58 };
59 59
60 DEFINE_TYPE_CASTS(ClassCollection, LiveNodeListBase, collection, collection->typ e() == ClassCollectionType, collection.type() == ClassCollectionType); 60 DEFINE_TYPE_CASTS(ClassCollection, LiveNodeListBase, collection, collection->typ e() == ClassCollectionType, collection.type() == ClassCollectionType);
61 61
62 inline bool ClassCollection::elementMatches(const Element& testElement) const 62 inline bool ClassCollection::elementMatches(const Element& testElement) const
63 { 63 {
64 if (!testElement.hasClass()) 64 if (!testElement.hasClass())
65 return false; 65 return false;
66 if (!m_classNames.size()) 66 if (!m_classNames.size())
67 return false; 67 return false;
68 // FIXME: DOM4 allows getElementsByClassName to return non StyledElement.
69 // https://bugs.webkit.org/show_bug.cgi?id=94718
70 if (!testElement.isStyledElement())
71 return false;
72 return testElement.classNames().containsAll(m_classNames); 68 return testElement.classNames().containsAll(m_classNames);
73 } 69 }
74 70
75 } // namespace blink 71 } // namespace blink
76 72
77 #endif // ClassCollection_h 73 #endif // ClassCollection_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/getElementsByClassName/non-styled-elements-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698