Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 458503002: Add diagnostics_writer.cc to the list of files allowed to printf. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang, M-A Ruel
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add diagnostics_writer.cc to the list of files allowed to printf. BUG= TBR=maruel Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288440

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 13 (0 generated)
Nico
6 years, 4 months ago (2014-08-08 16:14:45 UTC) #1
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-08 18:35:47 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-08 18:36:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/458503002/1
6 years, 4 months ago (2014-08-08 18:38:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 20:22:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 20:25:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3009)
6 years, 4 months ago (2014-08-08 20:25:27 UTC) #7
Lei Zhang
6 years, 4 months ago (2014-08-08 20:32:16 UTC) #8
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-08 21:23:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/458503002/1
6 years, 4 months ago (2014-08-08 21:26:02 UTC) #10
commit-bot: I haz the power
Change committed as 288440
6 years, 4 months ago (2014-08-08 21:33:22 UTC) #11
Nico
https://codereview.chromium.org/458503002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/458503002/diff/1/PRESUBMIT.py#newcode924 PRESUBMIT.py:924: r"diagnostics_writer.cc" durr, this is missing a trailing `,`. Follow-up ...
6 years, 4 months ago (2014-08-08 22:01:36 UTC) #12
M-A Ruel
6 years, 4 months ago (2014-08-09 00:51:30 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/458503002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/458503002/diff/1/PRESUBMIT.py#newcode924
PRESUBMIT.py:924: r"diagnostics_writer.cc"
On 2014/08/08 22:01:36, Nico (very away) wrote:
> durr, this is missing a trailing `,`. Follow-up coming up… :-(

+ is unnecessary.

Why no ^?

Please sort.

Powered by Google App Engine
This is Rietveld 408576698