Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 902 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 913 black_list = (_EXCLUDED_PATHS + | 913 black_list = (_EXCLUDED_PATHS + |
| 914 _TEST_CODE_EXCLUDED_PATHS + | 914 _TEST_CODE_EXCLUDED_PATHS + |
| 915 input_api.DEFAULT_BLACK_LIST + | 915 input_api.DEFAULT_BLACK_LIST + |
| 916 (r"^base[\\\/]logging\.h$", | 916 (r"^base[\\\/]logging\.h$", |
| 917 r"^base[\\\/]logging\.cc$", | 917 r"^base[\\\/]logging\.cc$", |
| 918 r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$", | 918 r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$", |
| 919 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", | 919 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", |
| 920 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]" | 920 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]" |
| 921 r"startup_browser_creator\.cc$", | 921 r"startup_browser_creator\.cc$", |
| 922 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", | 922 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", |
| 923 r"chrome[\\\/]browser[\\\/]diagnostics[\\\/]" + | |
| 924 r"diagnostics_writer.cc" | |
|
Nico
2014/08/08 22:01:36
durr, this is missing a trailing `,`. Follow-up co
M-A Ruel
2014/08/09 00:51:30
+ is unnecessary.
Why no ^?
Please sort.
| |
| 923 r"^chrome_elf[\\\/]dll_hash[\\\/]dll_hash_main\.cc$", | 925 r"^chrome_elf[\\\/]dll_hash[\\\/]dll_hash_main\.cc$", |
| 924 r"^chromecast[\\\/]", | 926 r"^chromecast[\\\/]", |
| 925 r"^cloud_print[\\\/]", | 927 r"^cloud_print[\\\/]", |
| 926 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]" | 928 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]" |
| 927 r"gl_helper_benchmark\.cc$", | 929 r"gl_helper_benchmark\.cc$", |
| 928 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$", | 930 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$", |
| 929 r"^native_client_sdk[\\\/]", | 931 r"^native_client_sdk[\\\/]", |
| 930 r"^remoting[\\\/]base[\\\/]logging\.h$", | 932 r"^remoting[\\\/]base[\\\/]logging\.h$", |
| 931 r"^remoting[\\\/]host[\\\/].*", | 933 r"^remoting[\\\/]host[\\\/].*", |
| 932 r"^sandbox[\\\/]linux[\\\/].*", | 934 r"^sandbox[\\\/]linux[\\\/].*", |
| (...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1622 builders.extend(['cros_x86']) | 1624 builders.extend(['cros_x86']) |
| 1623 | 1625 |
| 1624 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1626 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
| 1625 # unless they're .gyp(i) files as changes to those files can break the gyp | 1627 # unless they're .gyp(i) files as changes to those files can break the gyp |
| 1626 # step on that bot. | 1628 # step on that bot. |
| 1627 if (not all(re.search('^chrome', f) for f in files) or | 1629 if (not all(re.search('^chrome', f) for f in files) or |
| 1628 any(re.search('\.gypi?$', f) for f in files)): | 1630 any(re.search('\.gypi?$', f) for f in files)): |
| 1629 builders.extend(['android_aosp']) | 1631 builders.extend(['android_aosp']) |
| 1630 | 1632 |
| 1631 return GetDefaultTryConfigs(builders) | 1633 return GetDefaultTryConfigs(builders) |
| OLD | NEW |