Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 458503002: Add diagnostics_writer.cc to the list of files allowed to printf. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index a9d0502bcc0d8ffb1ab9d7b9b1af915bb44a2eb8..446d910272c3ecdc8a2160eef62a184cb6df963e 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -920,6 +920,8 @@ def _CheckSpamLogging(input_api, output_api):
r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]"
r"startup_browser_creator\.cc$",
r"^chrome[\\\/]installer[\\\/]setup[\\\/].*",
+ r"chrome[\\\/]browser[\\\/]diagnostics[\\\/]" +
+ r"diagnostics_writer.cc"
Nico 2014/08/08 22:01:36 durr, this is missing a trailing `,`. Follow-up co
M-A Ruel 2014/08/09 00:51:30 + is unnecessary. Why no ^? Please sort.
r"^chrome_elf[\\\/]dll_hash[\\\/]dll_hash_main\.cc$",
r"^chromecast[\\\/]",
r"^cloud_print[\\\/]",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698