chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc ('k') | chrome/browser/guest_view/guest_view_base.cc » ('j') | chrome/test/data/extensions/platform_apps/web_view/background/background.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index cef53ffaed2bf9743efe65bbc5ddfa490e2d0a9b..8e3da92d1eab1e6507b4649480f533b1823a7ec2 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -990,7 +990,7 @@ bool TabsGetFunction::RunSync() {

bool TabsGetCurrentFunction::RunSync() {

DCHECK(dispatcher());

- WebContents* contents = dispatcher()->delegate()->GetAssociatedWebContents();

+ WebContents* contents = dispatcher()->delegate()->GetVisibleWebContents();

if (contents)

SetResult(ExtensionTabUtil::CreateTabValue(contents, extension()));