chrome/test/data/extensions/platform_apps/web_view/background/background.html - Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/background/background.html

Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/guest_view_base.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/background/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/web_view/background/background.html

diff --git a/chrome/test/data/extensions/api_test/extension_options/embed_self/test.html b/chrome/test/data/extensions/platform_apps/web_view/background/background.html

similarity index 67%

copy from chrome/test/data/extensions/api_test/extension_options/embed_self/test.html

copy to chrome/test/data/extensions/platform_apps/web_view/background/background.html

index 9580339ef42e74ed6fb1a20a658c395114c367f7..14b2a84fbaa97537ed6b5fb1117aa94204b7ff1a 100644

--- a/chrome/test/data/extensions/api_test/extension_options/embed_self/test.html

+++ b/chrome/test/data/extensions/platform_apps/web_view/background/background.html

@@ -5,6 +5,7 @@

-->

<html>

<body>

- <script src="test.js"></script>

+ <webview src="data:text/html,<body>One</body>"></webview>

Fady Samuel 2014/08/11 21:07:17 Don't pre-navigate the webview. That could be racy

not at google - send to devlin 2014/08/11 21:41:34 Done.

+ <script src="background.js"></script>

</body>

</html>