chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc - Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/web_view_browsertest.cc ('k') | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | chrome/test/data/extensions/platform_apps/web_view/background/background.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

diff --git a/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc b/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

index c56fe86628ccf565660dedb1abcbfe27cc8b31a1..2887c8af40fa3e0a2371762199d9d48736d610ed 100644

--- a/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

+++ b/chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc

@@ -39,7 +39,7 @@ bool ReadingListPrivateAddEntryFunction::RunAsync() {

DomDistillerService* service =

DomDistillerServiceFactory::GetForBrowserContext(GetProfile());

gfx::Size render_view_size;

- content::WebContents* web_contents = GetAssociatedWebContents();

+ content::WebContents* web_contents = GetVisibleWebContents();

if (web_contents)

render_view_size = web_contents->GetContainerBounds().size();

const std::string& id = service->AddToList(