Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the (Closed)

Created:
6 years, 4 months ago by not at google - send to devlin
Modified:
6 years, 4 months ago
Reviewers:
Fady Samuel, James Cook
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Change GuestViewInternalCreateGuestFunction to create the guest view using the calling WebContents, not whatever the "associated" WebContents is. BUG=402318 R=fsamuel@chromium.org, jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289118

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : add test #

Total comments: 2

Patch Set 4 : test #

Patch Set 5 : fix popups #

Patch Set 6 : clenaup #

Patch Set 7 : REAL FIX OMG #

Patch Set 8 : rebase #

Patch Set 9 : argh #

Patch Set 10 : rebaseeeeeee #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/web_view/background/background.html View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/web_view/background/background.js View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/web_view/background/manifest.json View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
not at google - send to devlin
jamescook@ for extensions stuff fsamuel@ for the test (and the tiny guestview change I suppose).
6 years, 4 months ago (2014-08-11 20:59:53 UTC) #1
Fady Samuel
https://codereview.chromium.org/458323002/diff/40001/chrome/test/data/extensions/platform_apps/web_view/background/background.html File chrome/test/data/extensions/platform_apps/web_view/background/background.html (right): https://codereview.chromium.org/458323002/diff/40001/chrome/test/data/extensions/platform_apps/web_view/background/background.html#newcode8 chrome/test/data/extensions/platform_apps/web_view/background/background.html:8: <webview src="data:text/html,<body>One</body>"></webview> Don't pre-navigate the webview. That could be ...
6 years, 4 months ago (2014-08-11 21:07:17 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/458323002/diff/40001/chrome/test/data/extensions/platform_apps/web_view/background/background.html File chrome/test/data/extensions/platform_apps/web_view/background/background.html (right): https://codereview.chromium.org/458323002/diff/40001/chrome/test/data/extensions/platform_apps/web_view/background/background.html#newcode8 chrome/test/data/extensions/platform_apps/web_view/background/background.html:8: <webview src="data:text/html,<body>One</body>"></webview> On 2014/08/11 21:07:17, Fady Samuel wrote: > ...
6 years, 4 months ago (2014-08-11 21:41:34 UTC) #3
Fady Samuel
guest_view/web_view lgtm
6 years, 4 months ago (2014-08-11 21:43:55 UTC) #4
not at google - send to devlin
Sorry James, I'm going to check the CQ now since this is a crash that ...
6 years, 4 months ago (2014-08-11 22:35:33 UTC) #5
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 4 months ago (2014-08-11 22:35:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/458323002/100001
6 years, 4 months ago (2014-08-11 22:39:57 UTC) #7
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 4 months ago (2014-08-12 00:30:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/458323002/110001
6 years, 4 months ago (2014-08-12 00:38:17 UTC) #9
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 4 months ago (2014-08-12 02:29:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/458323002/130001
6 years, 4 months ago (2014-08-12 02:31:20 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 05:33:48 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 06:10:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/3196)
6 years, 4 months ago (2014-08-12 06:10:46 UTC) #14
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 4 months ago (2014-08-12 14:34:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/458323002/130001
6 years, 4 months ago (2014-08-12 14:37:20 UTC) #16
not at google - send to devlin
ok I found a much easier way to implement this. sigh.
6 years, 4 months ago (2014-08-12 16:20:56 UTC) #17
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 4 months ago (2014-08-12 16:21:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/458323002/150001
6 years, 4 months ago (2014-08-12 16:21:15 UTC) #19
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 4 months ago (2014-08-12 20:30:18 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/458323002/170001
6 years, 4 months ago (2014-08-12 20:33:05 UTC) #21
not at google - send to devlin
6 years, 4 months ago (2014-08-12 23:45:45 UTC) #22
Message was sent while issue was closed.
Committed patchset #10 manually as 289118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698