chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc - Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebaseeeeeee Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/web_view_browsertest.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/background/background.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

diff --git a/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc b/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

index f16f353a40eb2879fd157a08d2b2ac8e9b59cd4e..0e898a49a3ab8168de7916394bb02e447ab85941 100644

--- a/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

+++ b/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

@@ -33,12 +33,19 @@ bool GuestViewInternalCreateGuestFunction::RunAsync() {

GuestViewManager::WebContentsCreatedCallback callback =

base::Bind(&GuestViewInternalCreateGuestFunction::CreateGuestCallback,

this);

+ content::WebContents* embedder_web_contents =

+ content::WebContents::FromRenderViewHost(render_view_host());

+ if (!embedder_web_contents) {

+ error_ = "Guest views can only be embedded in web content";

+ return false;

+ }

guest_view_manager->CreateGuest(view_type,

extension_id(),

- GetAssociatedWebContents(),

+ embedder_web_contents,

*create_params,

callback);

return true;

}