chrome/test/data/extensions/platform_apps/web_view/background/background.html - Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/platform_apps/web_view/background/background.html

Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/guest_view/guest_view_base.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/background/background.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 * Copyright 2014 The Chromium Authors. All rights reserved. Use of this	2 * Copyright 2014 The Chromium Authors. All rights reserved. Use of this

3 * source code is governed by a BSD-style license that can be found in the	3 * source code is governed by a BSD-style license that can be found in the

4 * LICENSE file.	4 * LICENSE file.

5 -->	5 -->

6 <html>	6 <html>

7 <body>	7 <body>

8 <script src="test.js"></script>	8 <webview src="data:text/html,<body>One</body>"></webview>
	Fady Samuel 2014/08/11 21:07:17 Don't pre-navigate the webview. That could be racy Don't pre-navigate the webview. That could be racy. Don't include a src attribute here. Instead, assign the src in the test after a listener has been installed. not at google - send to devlin 2014/08/11 21:41:34 Done. Show quoted text On 2014/08/11 21:07:17, Fady Samuel wrote: > Don't pre-navigate the webview. That could be racy. Don't include a src > attribute here. Instead, assign the src in the test after a listener has been > installed. Done.
	9 <script src="background.js"></script>

9 </body>	10 </body>

10 </html>	11 </html>

OLD	NEW