Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 458313005: Cleanup namespace usage from animation to exported in platform/ (Closed)

Created:
6 years, 4 months ago by heeyoun.lee
Modified:
6 years, 4 months ago
Reviewers:
haraken, tkent, kangil_
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup namespace usage from animation to exported in platform/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180060

Patch Set 1 #

Patch Set 2 : Cleanup namespace usage in platform/animation ~ /exported #

Total comments: 4

Patch Set 3 : Cleanup namespace usage from animation to exported in platform/ #

Total comments: 6

Patch Set 4 : Cleanup namespace usage from animation to exported in platform/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -217 lines) Patch
M Source/platform/animation/TimingFunctionTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/audio/AudioBus.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/audio/AudioDSPKernel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioDestination.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/audio/AudioDestination.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/audio/AudioDestinationConsumer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/HRTFDatabaseLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/HRTFDatabaseLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/ReverbConvolver.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/audio/ReverbConvolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blob/BlobData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blob/BlobRegistry.cpp View 1 2 3 3 chunks +2 lines, -7 lines 0 comments Download
M Source/platform/exported/WebAudioBus.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebBlobData.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebContentDecryptionModuleResult.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebConvertableToTraceFormat.cpp View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/exported/WebCryptoResult.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebCursorInfo.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebData.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebFileSystemCallbacks.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/exported/WebHTTPBody.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebHTTPLoadInfo.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/exported/WebImageSkia.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebMediaStream.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M Source/platform/exported/WebMediaStreamSource.cpp View 5 chunks +4 lines, -6 lines 0 comments Download
M Source/platform/exported/WebMediaStreamTrack.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/platform/exported/WebMediaStreamTrackSourcesRequest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebPermissionCallbacks.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebPrerender.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/exported/WebPrerenderingSupport.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebRTCConfiguration.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebRTCOfferOptions.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebRTCSessionDescriptionRequest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebRTCStatsRequest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebRTCStatsResponse.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/exported/WebRTCVoidRequest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebSchedulerProxy.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebScrollbarImpl.h View 1 2 2 chunks +4 lines, -7 lines 0 comments Download
M Source/platform/exported/WebScrollbarImpl.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/exported/WebScrollbarThemeClientImpl.cpp View 1 4 chunks +11 lines, -13 lines 0 comments Download
M Source/platform/exported/WebScrollbarThemeGeometryNative.h View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/platform/exported/WebScrollbarThemeGeometryNative.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/platform/exported/WebSerializedOrigin.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebServiceWorkerProxy.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/exported/WebServiceWorkerRequest.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/exported/WebServiceWorkerResponse.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/exported/WebSocketHandshakeRequestInfo.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebSocketHandshakeResponseInfo.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebSocketStreamError.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/exported/WebSpeechSynthesisUtterance.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/platform/exported/WebSpeechSynthesisVoice.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebSpeechSynthesizerClientImpl.h View 1 1 chunk +9 lines, -9 lines 0 comments Download
M Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/platform/exported/WebStorageQuotaCallbacks.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/exported/WebThreadSafeData.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebURL.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/exported/WebURLError.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebURLLoadTiming.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebURLRequest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebURLRequestPrivate.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/exported/WebURLResponse.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebURLResponsePrivate.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/exported/WrappedResourceRequest.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/exported/WrappedResourceResponse.h View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
heeyoun.lee
6 years, 4 months ago (2014-08-12 07:56:28 UTC) #1
kangil_
https://codereview.chromium.org/458313005/diff/20001/Source/platform/exported/WebConvertableToTraceFormat.cpp File Source/platform/exported/WebConvertableToTraceFormat.cpp (right): https://codereview.chromium.org/458313005/diff/20001/Source/platform/exported/WebConvertableToTraceFormat.cpp#newcode33 Source/platform/exported/WebConvertableToTraceFormat.cpp:33: } // namespace blink https://codereview.chromium.org/458313005/diff/20001/Source/platform/exported/WebScrollbarImpl.h File Source/platform/exported/WebScrollbarImpl.h (right): https://codereview.chromium.org/458313005/diff/20001/Source/platform/exported/WebScrollbarImpl.h#newcode38 ...
6 years, 4 months ago (2014-08-12 08:20:32 UTC) #2
heeyoun.lee
PTAL
6 years, 4 months ago (2014-08-12 08:24:44 UTC) #3
heeyoun.lee
https://codereview.chromium.org/458313005/diff/20001/Source/platform/exported/WebConvertableToTraceFormat.cpp File Source/platform/exported/WebConvertableToTraceFormat.cpp (right): https://codereview.chromium.org/458313005/diff/20001/Source/platform/exported/WebConvertableToTraceFormat.cpp#newcode33 Source/platform/exported/WebConvertableToTraceFormat.cpp:33: } On 2014/08/12 08:20:32, kangil_ wrote: > // namespace ...
6 years, 4 months ago (2014-08-12 08:34:54 UTC) #4
kangil_
Not an owner lgtm. @haraken: Would you take a look at this CL? Thanks!
6 years, 4 months ago (2014-08-12 08:37:58 UTC) #5
haraken
LGTM, nice cleanup.
6 years, 4 months ago (2014-08-12 08:54:24 UTC) #6
haraken
tkent-san: rubberstamp please as an OWNER? heeyoun, kangil: Please don't remove blink-reviews@chromium.org and other email ...
6 years, 4 months ago (2014-08-12 08:55:40 UTC) #7
heeyoun.lee
On 2014/08/12 08:55:40, haraken wrote: > tkent-san: rubberstamp please as an OWNER? > > heeyoun, ...
6 years, 4 months ago (2014-08-12 08:57:03 UTC) #8
heeyoun.lee
The CQ bit was checked by heeyoun.lee@samsung.com
6 years, 4 months ago (2014-08-12 08:57:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heeyoun.lee@samsung.com/458313005/40001
6 years, 4 months ago (2014-08-12 08:58:53 UTC) #10
tkent
https://codereview.chromium.org/458313005/diff/40001/Source/platform/blob/BlobRegistry.cpp File Source/platform/blob/BlobRegistry.cpp (right): https://codereview.chromium.org/458313005/diff/40001/Source/platform/blob/BlobRegistry.cpp#newcode52 Source/platform/blob/BlobRegistry.cpp:52: using WTF::ThreadSpecific; nit: We can remove this too. https://codereview.chromium.org/458313005/diff/40001/Source/platform/exported/WebURLRequestPrivate.h ...
6 years, 4 months ago (2014-08-12 09:02:34 UTC) #11
heeyoun.lee
The CQ bit was unchecked by heeyoun.lee@samsung.com
6 years, 4 months ago (2014-08-12 09:03:16 UTC) #12
heeyoun.lee
https://codereview.chromium.org/458313005/diff/40001/Source/platform/blob/BlobRegistry.cpp File Source/platform/blob/BlobRegistry.cpp (right): https://codereview.chromium.org/458313005/diff/40001/Source/platform/blob/BlobRegistry.cpp#newcode52 Source/platform/blob/BlobRegistry.cpp:52: using WTF::ThreadSpecific; On 2014/08/12 09:02:34, tkent wrote: > nit: ...
6 years, 4 months ago (2014-08-12 09:06:57 UTC) #13
tkent
lgtm
6 years, 4 months ago (2014-08-12 09:10:44 UTC) #14
heeyoun.lee
The CQ bit was unchecked by heeyoun.lee@samsung.com
6 years, 4 months ago (2014-08-12 09:11:34 UTC) #15
heeyoun.lee
The CQ bit was checked by heeyoun.lee@samsung.com
6 years, 4 months ago (2014-08-12 09:11:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heeyoun.lee@samsung.com/458313005/60001
6 years, 4 months ago (2014-08-12 09:12:29 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 10:39:17 UTC) #18
Message was sent while issue was closed. 
Change committed as 180060

Powered by Google App Engine
This is Rietveld 408576698