Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 457813002: Put GPU isolate targets under archive_gpu_tests=1 GYP variable. (Closed)

Created:
6 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 4 months ago
Reviewers:
jabdelmalek, bajones
CC:
chromium-reviews, jam
Project:
chromium
Visibility:
Public.

Description

Put GPU isolate targets under archive_gpu_tests=1 GYP variable. This avoids the majority of the Chromium builders attempting to build these isolates. BUG=401985 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -87 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +95 lines, -87 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Ken Russell (switch to Gerrit)
Brandon: PTAL This depends on https://codereview.chromium.org/452083003 , which must land and cycle through all the ...
6 years, 4 months ago (2014-08-08 21:28:58 UTC) #1
bajones
lgtm
6 years, 4 months ago (2014-08-08 21:58:30 UTC) #2
jabdelmalek
On 2014/08/08 21:58:30, bajones wrote: > lgtm can we CQ this now?
6 years, 4 months ago (2014-08-11 17:20:35 UTC) #3
jabdelmalek
On 2014/08/11 17:20:35, jabdelmalek wrote: > On 2014/08/08 21:58:30, bajones wrote: > > lgtm > ...
6 years, 4 months ago (2014-08-11 17:28:17 UTC) #4
jabdelmalek
The CQ bit was checked by jabdelmalek@google.com
6 years, 4 months ago (2014-08-11 17:28:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/457813002/1
6 years, 4 months ago (2014-08-11 17:30:20 UTC) #6
Ken Russell (switch to Gerrit)
On 2014/08/11 17:28:17, jabdelmalek wrote: > On 2014/08/11 17:20:35, jabdelmalek wrote: > > On 2014/08/08 ...
6 years, 4 months ago (2014-08-11 17:31:22 UTC) #7
jabdelmalek
The CQ bit was unchecked by jabdelmalek@google.com
6 years, 4 months ago (2014-08-11 19:24:36 UTC) #8
jabdelmalek
The CQ bit was checked by jabdelmalek@google.com
6 years, 4 months ago (2014-08-11 19:24:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/457813002/1
6 years, 4 months ago (2014-08-11 19:25:01 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-11 20:24:24 UTC) #11
jabdelmalek
On 2014/08/11 20:24:24, I haz the power (commit-bot) wrote: > FYI, CQ is re-trying this ...
6 years, 4 months ago (2014-08-11 20:25:45 UTC) #12
jabdelmalek
The CQ bit was unchecked by jabdelmalek@google.com
6 years, 4 months ago (2014-08-11 20:25:54 UTC) #13
jabdelmalek
The CQ bit was checked by jabdelmalek@google.com
6 years, 4 months ago (2014-08-11 20:25:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/457813002/1
6 years, 4 months ago (2014-08-11 20:28:23 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 20:36:09 UTC) #16
Message was sent while issue was closed.
Change committed as 288789

Powered by Google App Engine
This is Rietveld 408576698