Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 452083003: Specify GYP variable archive_gpu_tests=1 on GPU bots. (Closed)

Created:
6 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 4 months ago
Reviewers:
bajones
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, jam, kjellander-cc_chromium.org, pgervais+watch_chromium.org, stip+watch_chromium.org, Zhenyao Mo
Project:
tools
Visibility:
Public.

Description

Specify GYP variable archive_gpu_tests=1 on GPU bots. The GPU isolates will be covered under this variable to prevent them from being built on non-GPU bots. BUG=401985 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -33 lines) Patch
M scripts/slave/recipe_modules/gpu/api.py View 1 chunk +5 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/killall_gnome_keyring_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_blink.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_tryserver.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_blink.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_tryserver.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_blink.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_tryserver.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_blink.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_git.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_skip_checkout.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver_blink.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_blink.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_tryserver.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_blink.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_fyi.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/clobber_after_tryserver_failed_compile.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/compile_fail_is_critical_on_main.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/linux_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/linux_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release_gclient_revert_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release_tot_angle.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Russell (switch to Gerrit)
Brandon: PTAL I'll send out a Chromium-side review shortly putting the GPU isolates under this ...
6 years, 4 months ago (2014-08-08 21:22:58 UTC) #1
bajones
lgtm
6 years, 4 months ago (2014-08-08 21:25:50 UTC) #2
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 4 months ago (2014-08-08 21:29:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/452083003/1
6 years, 4 months ago (2014-08-08 21:30:03 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 21:31:16 UTC) #5
Message was sent while issue was closed. 
Change committed as 288437

Powered by Google App Engine
This is Rietveld 408576698