Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 457663002: Convert more fullscreen tests to reftests (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Convert more fullscreen tests to reftests This removes ~242 KB of *-expected.png and leaves only a few platform-specific expectations left in LayoutTests/platform/linux/virtual/android/fullscreen/ Some tests were simultaneously pixel tests and text tests, which is not great for a reftest. To avoid having the (formated) log output in *-expected.html, instead make those tests time out if any check fails. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180036

Patch Set 1 #

Patch Set 2 : doctype matters for margins #

Total comments: 14

Patch Set 3 : address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -169 lines) Patch
M LayoutTests/fullscreen/full-screen-iframe-zIndex.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-placeholder.html View 1 2 3 chunks +24 lines, -31 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-placeholder-expected.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-remove-ancestor-after.html View 1 2 2 chunks +17 lines, -13 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-remove-ancestor-after-expected.html View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-remove-ancestor-after-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-stacking-context.html View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-stacking-context-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-stacking-context-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-zIndex-after.html View 1 2 3 chunks +11 lines, -14 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-zIndex-after-expected.html View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-zIndex-after-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fullscreen/resources/inner.html View 1 1 chunk +2 lines, -3 lines 0 comments Download
D LayoutTests/platform/linux/fullscreen/full-screen-iframe-zIndex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/linux/fullscreen/full-screen-remove-ancestor-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fullscreen/full-screen-stacking-context-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fullscreen/full-screen-zIndex-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-zIndex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-remove-ancestor-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-stacking-context-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-zIndex-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fullscreen/full-screen-iframe-zIndex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fullscreen/full-screen-remove-ancestor-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fullscreen/full-screen-zIndex-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/fullscreen/full-screen-remove-ancestor-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fullscreen/full-screen-iframe-zIndex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/mac/fullscreen/full-screen-remove-ancestor-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fullscreen/full-screen-stacking-context-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fullscreen/full-screen-zIndex-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fullscreen/full-screen-iframe-zIndex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/win-xp/fullscreen/full-screen-remove-ancestor-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fullscreen/full-screen-stacking-context-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fullscreen/full-screen-zIndex-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fullscreen/full-screen-iframe-zIndex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/win/fullscreen/full-screen-remove-ancestor-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fullscreen/full-screen-stacking-context-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fullscreen/full-screen-zIndex-after-expected.png View Binary file 0 comments Download
D LayoutTests/virtual/android/fullscreen/full-screen-stacking-context-expected.png View Binary file 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
PTAL. Some tests are maybe a little bit worse off because of this, let me ...
6 years, 4 months ago (2014-08-08 12:13:22 UTC) #1
philipj_slow
doctype matters for margins
6 years, 4 months ago (2014-08-08 12:54:49 UTC) #2
falken
Thanks for doing this. I rather like the descriptions and manual buttons. They help me ...
6 years, 4 months ago (2014-08-11 02:34:05 UTC) #3
philipj_slow
https://codereview.chromium.org/457663002/diff/20001/LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html File LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html (right): https://codereview.chromium.org/457663002/diff/20001/LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html#newcode2 LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html:2: <button>Go full screen</button> On 2014/08/11 02:34:04, falken wrote: > ...
6 years, 4 months ago (2014-08-11 11:22:09 UTC) #4
falken
LGTM https://codereview.chromium.org/457663002/diff/20001/LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html File LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html (right): https://codereview.chromium.org/457663002/diff/20001/LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html#newcode2 LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html:2: <button>Go full screen</button> On 2014/08/11 11:22:08, philipj wrote: ...
6 years, 4 months ago (2014-08-12 00:18:00 UTC) #5
philipj_slow
https://codereview.chromium.org/457663002/diff/20001/LayoutTests/fullscreen/full-screen-stacking-context-expected.html File LayoutTests/fullscreen/full-screen-stacking-context-expected.html (right): https://codereview.chromium.org/457663002/diff/20001/LayoutTests/fullscreen/full-screen-stacking-context-expected.html#newcode4 LayoutTests/fullscreen/full-screen-stacking-context-expected.html:4: var runPixelTests = true; On 2014/08/12 00:18:00, falken wrote: ...
6 years, 4 months ago (2014-08-12 06:41:20 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-12 06:41:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/457663002/40001
6 years, 4 months ago (2014-08-12 06:42:28 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 06:46:37 UTC) #9
Message was sent while issue was closed.
Change committed as 180036

Powered by Google App Engine
This is Rietveld 408576698