LayoutTests/fullscreen/full-screen-stacking-context-expected.html - Issue 457663002: Convert more fullscreen tests to reftests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-stacking-context-expected.html

Issue 457663002: Convert more fullscreen tests to reftests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: doctype matters for margins Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fullscreen/full-screen-placeholder-expected.html ('K') | « LayoutTests/fullscreen/full-screen-stacking-context.html ('k') | LayoutTests/fullscreen/full-screen-stacking-context-expected.txt » ('j') | LayoutTests/fullscreen/full-screen-zIndex-after.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <video></video>

	3 <script>

	4 var runPixelTests = true;
	falken 2014/08/11 02:34:05 I'm not positive, but it might be possible to remo I'm not positive, but it might be possible to remove these runPixelTests variables now that everything is a reftest. philipj_slow 2014/08/11 11:22:08 Unfortunately it isn't, calling testRunner.dumpAsT Show quoted text On 2014/08/11 02:34:05, falken wrote: > I'm not positive, but it might be possible to remove these runPixelTests > variables now that everything is a reftest. Unfortunately it isn't, calling testRunner.dumpAsText() makes the test fail, expecting "pass" but getting "image". Splitting runWithKeyDown into a separate script would help, though, if you think it's worth it. falken 2014/08/12 00:18:00 Ah, this is because not all users of full-screen-t Show quoted text On 2014/08/11 11:22:08, philipj wrote: > On 2014/08/11 02:34:05, falken wrote: > > I'm not positive, but it might be possible to remove these runPixelTests > > variables now that everything is a reftest. > > Unfortunately it isn't, calling testRunner.dumpAsText() makes the test fail, > expecting "pass" but getting "image". Splitting runWithKeyDown into a separate > script would help, though, if you think it's worth it. Ah, this is because not all users of full-screen-tests.js are ref tests? I was thinking it may be possible to delete the lines: if (window.runPixelTests) testRunner.dumpAsTextWithPixelResults(); else testRunner.dumpAsText(); philipj_slow 2014/08/12 06:41:20 No, that can't be removed just yet. However, after Show quoted text On 2014/08/12 00:18:00, falken wrote: > On 2014/08/11 11:22:08, philipj wrote: > > On 2014/08/11 02:34:05, falken wrote: > > > I'm not positive, but it might be possible to remove these runPixelTests > > > variables now that everything is a reftest. > > > > Unfortunately it isn't, calling testRunner.dumpAsText() makes the test fail, > > expecting "pass" but getting "image". Splitting runWithKeyDown into a separate > > script would help, though, if you think it's worth it. > > Ah, this is because not all users of full-screen-tests.js are ref tests? I was > thinking it may be possible to delete the lines: > if (window.runPixelTests) > testRunner.dumpAsTextWithPixelResults(); > else > testRunner.dumpAsText(); No, that can't be removed just yet. However, after trust-event.js has landed maybe I can convert some reftests to use that instead, getting rid of runPixelTests.
	5 </script>

	6 <script src="full-screen-test.js"></script>

	7 <script>

	8 document.onwebkitfullscreenchange = endTest;

	9 runWithKeyDown(function() {

	10 document.querySelector("video").webkitRequestFullScreen();

	11 });

	12 </script>

OLD	NEW