LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html - Issue 457663002: Convert more fullscreen tests to reftests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html

Issue 457663002: Convert more fullscreen tests to reftests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: doctype matters for margins Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <button>Go full screen</button>
	falken 2014/08/11 02:34:04 Out of scope for this patch, but... this test is Out of scope for this patch, but... this test is pretty confusing. It says only a "white box" should be visible but it shows this button which made me think at first the test doesn't even exercise fullscreen. I see now though the iframe that goes fullscreen has this button which isn't used in the test. We should also add a z-index: max_int test which shows crbug.com/398599 philipj_slow 2014/08/11 11:22:08 I've updated the test to use empty.html instead an Show quoted text On 2014/08/11 02:34:04, falken wrote: > Out of scope for this patch, but... > > this test is pretty confusing. It says only a "white box" should be visible but > it shows this button which made me think at first the test doesn't even exercise > fullscreen. I see now though the iframe that goes fullscreen has this button > which isn't used in the test. I've updated the test to use empty.html instead and tweaked the description. Show quoted text > We should also add a z-index: max_int test which shows crbug.com/398599 Is the attached zindex-defeats-fullscreen.html still good? Wanna create a review? falken 2014/08/12 00:17:59 Thanks! Show quoted text On 2014/08/11 11:22:08, philipj wrote: > On 2014/08/11 02:34:04, falken wrote: > > Out of scope for this patch, but... > > > > this test is pretty confusing. It says only a "white box" should be visible > but > > it shows this button which made me think at first the test doesn't even > exercise > > fullscreen. I see now though the iframe that goes fullscreen has this button > > which isn't used in the test. > > I've updated the test to use empty.html instead and tweaked the description. Thanks! Show quoted text > > > We should also add a z-index: max_int test which shows crbug.com/398599 > > Is the attached zindex-defeats-fullscreen.html still good? Wanna create a > review? Good idea, I'll do that.
OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.txt » ('j') | LayoutTests/fullscreen/full-screen-placeholder.html » ('J')