Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 456763002: Get rid of SVGPathSegRole (Closed)

Created:
6 years, 4 months ago by rtakacs
Modified:
6 years, 4 months ago
Reviewers:
pdr., krit, kouhei (in TOK)
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, Eric Willigers, rtakacs_inf.u-szeged.hu
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Get rid of SVGPathSegRole SVGPathSegRole is removed since it was not used at all. BUG=401943 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -152 lines) Patch
M Source/core/svg/SVGAnimatedPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 1 chunk +19 lines, -19 lines 0 comments Download
M Source/core/svg/SVGPathSeg.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/svg/SVGPathSegArc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegArcAbs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegArcRel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegClosePath.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubic.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicAbs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicRel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmooth.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadratic.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticAbs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticRel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoAbs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalAbs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalRel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoRel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVertical.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalAbs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalRel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegList.h View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPathSegList.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/svg/SVGPathSegListBuilder.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegListBuilder.cpp View 10 chunks +19 lines, -20 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoAbs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoRel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegWithContext.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rtakacs
I began to deal with a "FIXME: remove second unused argument from all derived classes." ...
6 years, 4 months ago (2014-08-08 15:58:04 UTC) #1
kouhei (in TOK)
On 2014/08/08 15:58:04, rtakacs wrote: > I began to deal with a "FIXME: remove second ...
6 years, 4 months ago (2014-08-08 16:14:18 UTC) #2
rtakacs
The CQ bit was checked by rtakacs.u-szeged@partner.samsung.com
6 years, 4 months ago (2014-08-08 16:37:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtakacs.u-szeged@partner.samsung.com/456763002/1
6 years, 4 months ago (2014-08-08 16:38:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-08 18:37:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 19:32:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/12299)
6 years, 4 months ago (2014-08-08 19:32:02 UTC) #7
pdr.
On 2014/08/08 19:32:02, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 4 months ago (2014-08-08 20:07:05 UTC) #8
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 4 months ago (2014-08-08 20:07:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtakacs.u-szeged@partner.samsung.com/456763002/1
6 years, 4 months ago (2014-08-08 20:07:51 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 20:12:06 UTC) #11
Message was sent while issue was closed. 
Change committed as 179864

Powered by Google App Engine
This is Rietveld 408576698