bindings: Introduces type-check for the internal pointers.

Source/bindings/core/v8/custom/V8ArrayBufferCustom.h

Index: Source/bindings/core/v8/custom/V8ArrayBufferCustom.h
diff --git a/Source/bindings/core/v8/custom/V8ArrayBufferCustom.h b/Source/bindings/core/v8/custom/V8ArrayBufferCustom.h
index 986e0f1033d20c4bd9d0dd3463c6665a2870a699..a6d9821f0b84124275b9a83e5327850cc0aac299 100644
--- a/Source/bindings/core/v8/custom/V8ArrayBufferCustom.h
+++ b/Source/bindings/core/v8/custom/V8ArrayBufferCustom.h
@@ -54,20 +54,20 @@ public:
     static bool hasInstance(v8::Handle<v8::Value>, v8::Isolate*);
     static ArrayBuffer* toNative(v8::Handle<v8::Object>);
     static ArrayBuffer* toNativeWithTypeCheck(v8::Isolate*, v8::Handle<v8::Value>);
-    static void derefObject(void*);
+    static void derefObject(ScriptWrappableBase* internalPointer);
     static const WrapperTypeInfo wrapperTypeInfo;
     static const int internalFieldCount = v8DefaultWrapperInternalFieldCount;
     static void installPerContextEnabledProperties(v8::Handle<v8::Object>, ArrayBuffer*, v8::Isolate*) { }
     static void installPerContextEnabledMethods(v8::Handle<v8::Object>, v8::Isolate*) { }
 
-    static inline void* toInternalPointer(ArrayBuffer* impl)
+    static inline ScriptWrappableBase* toInternalPointer(ArrayBuffer* impl)
     {
-        return impl;
+        return reinterpret_cast<ScriptWrappableBase*>(impl);

[haraken, 2014/08/08 09:37:23]

Probably I'm wrong, but I guess this could be static_cast instead of
reinterpret_cast. I guess you can replace all reinterpret_casts in this CL with
static_casts, since all DOM objects now inherit from ScriptWrappableBase.

[Yuki, 2014/08/08 13:01:25]

Unfortunately that's not true that all DOM objects inherit from
ScriptWrappableBase.  We still have some exceptions.

At least WTF::ArrayBuffer doesn't inherit from ScriptWrappableBase, because wtf
shouldn't depend on bindings.  And this code is for ArrayBuffer.  We cannot
static_cast from ArrayBuffer to ScriptWrappableBase.

     }
 
-    static inline ArrayBuffer* fromInternalPointer(void* impl)
+    static inline ArrayBuffer* fromInternalPointer(ScriptWrappableBase* internalPointer)
     {
-        return static_cast<ArrayBuffer*>(impl);
+        return reinterpret_cast<ArrayBuffer*>(internalPointer);
     }
 
 private: