Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: Source/bindings/core/v8/custom/V8ArrayBufferCustom.cpp

Issue 456683002: bindings: Introduces type-check for the internal pointers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8ArrayBufferCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8ArrayBufferCustom.cpp b/Source/bindings/core/v8/custom/V8ArrayBufferCustom.cpp
index a1b8b8eab79f5f4bc773bee9769bc2b651dab2b0..ecef3748d1b462c97b8f47d3155b0a54288e459c 100644
--- a/Source/bindings/core/v8/custom/V8ArrayBufferCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8ArrayBufferCustom.cpp
@@ -56,9 +56,9 @@ bool V8ArrayBuffer::hasInstance(v8::Handle<v8::Value> value, v8::Isolate*)
return value->IsArrayBuffer();
}
-void V8ArrayBuffer::derefObject(void* object)
+void V8ArrayBuffer::derefObject(ScriptWrappableBase* internalPointer)
{
- static_cast<ArrayBuffer*>(object)->deref();
+ fromInternalPointer(internalPointer)->deref();
}
v8::Handle<v8::Object> V8ArrayBuffer::createWrapper(PassRefPtr<ArrayBuffer> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
@@ -79,7 +79,7 @@ ArrayBuffer* V8ArrayBuffer::toNative(v8::Handle<v8::Object> object)
v8::Local<v8::ArrayBuffer> v8buffer = object.As<v8::ArrayBuffer>();
if (v8buffer->IsExternal()) {
RELEASE_ASSERT(toWrapperTypeInfo(object)->ginEmbedder == gin::kEmbedderBlink);
- return reinterpret_cast<ArrayBuffer*>(blink::toNative(object));
+ return reinterpret_cast<ArrayBuffer*>(blink::toInternalPointer(object));
}
v8::ArrayBuffer::Contents v8Contents = v8buffer->Externalize();
@@ -88,7 +88,7 @@ ArrayBuffer* V8ArrayBuffer::toNative(v8::Handle<v8::Object> object)
RefPtr<ArrayBuffer> buffer = ArrayBuffer::create(contents);
V8DOMWrapper::associateObjectWithWrapper<V8ArrayBuffer>(buffer.release(), &wrapperTypeInfo, object, v8::Isolate::GetCurrent(), WrapperConfiguration::Dependent);
- return reinterpret_cast<ArrayBuffer*>(blink::toNative(object));
+ return reinterpret_cast<ArrayBuffer*>(blink::toInternalPointer(object));
}
ArrayBuffer* V8ArrayBuffer::toNativeWithTypeCheck(v8::Isolate* isolate, v8::Handle<v8::Value> value)

Powered by Google App Engine
This is Rietveld 408576698