bindings: Introduces type-check for the internal pointers.

Source/bindings/core/v8/custom/V8ArrayBufferCustom.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 36 matching lines @@
     {
         v8::Isolate::GetCurrent()->AdjustAmountOfExternalAllocatedMemory(static_cast<int>(sizeInBytes));
     }
 };
 
 class V8ArrayBuffer {
 public:
     static bool hasInstance(v8::Handle<v8::Value>, v8::Isolate*);
     static ArrayBuffer* toNative(v8::Handle<v8::Object>);
     static ArrayBuffer* toNativeWithTypeCheck(v8::Isolate*, v8::Handle<v8::Value>);
-    static void derefObject(void*);
+    static void derefObject(ScriptWrappableBase* internalPointer);
     static const WrapperTypeInfo wrapperTypeInfo;
     static const int internalFieldCount = v8DefaultWrapperInternalFieldCount;
     static void installPerContextEnabledProperties(v8::Handle<v8::Object>, ArrayBuffer*, v8::Isolate*) { }
     static void installPerContextEnabledMethods(v8::Handle<v8::Object>, v8::Isolate*) { }
 
-    static inline void* toInternalPointer(ArrayBuffer* impl)
+    static inline ScriptWrappableBase* toInternalPointer(ArrayBuffer* impl)
     {
-        return impl;
+        return reinterpret_cast<ScriptWrappableBase*>(impl);

[haraken, 2014/08/08 09:37:23]

Probably I'm wrong, but I guess this could be static_cast instead of
reinterpret_cast. I guess you can replace all reinterpret_casts in this CL with
static_casts, since all DOM objects now inherit from ScriptWrappableBase.

[Yuki, 2014/08/08 13:01:25]

Unfortunately that's not true that all DOM objects inherit from
ScriptWrappableBase.  We still have some exceptions.

At least WTF::ArrayBuffer doesn't inherit from ScriptWrappableBase, because wtf
shouldn't depend on bindings.  And this code is for ArrayBuffer.  We cannot
static_cast from ArrayBuffer to ScriptWrappableBase.

     }
 
-    static inline ArrayBuffer* fromInternalPointer(void* impl)
+    static inline ArrayBuffer* fromInternalPointer(ScriptWrappableBase* internalPointer)
     {
-        return static_cast<ArrayBuffer*>(impl);
+        return reinterpret_cast<ArrayBuffer*>(internalPointer);
     }
 
 private:
     friend v8::Handle<v8::Object> wrap(ArrayBuffer*, v8::Handle<v8::Object> creationContext, v8::Isolate*);
     static v8::Handle<v8::Object> createWrapper(PassRefPtr<ArrayBuffer>, v8::Handle<v8::Object> creationContext, v8::Isolate*);
 };
 
 inline v8::Handle<v8::Object> wrap(ArrayBuffer* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     ASSERT(impl);
@@ skipping 70 matching lines @@
 
 template<class CallbackInfo, class Wrappable>
 inline void v8SetReturnValueFast(const CallbackInfo& info, PassRefPtr< ArrayBuffer > impl, Wrappable* wrappable)
 {
     v8SetReturnValueFast(info, impl.get(), wrappable);
 }
 
 } // namespace blink
 
 #endif // V8ArrayBufferCustom_h