Issue 455763002: Unship unscopables and disable array.values iterators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455763002: Unship unscopables and disable array.values iterators (Closed)

Created:
6 years, 4 months ago by rossberg

Modified:
6 years, 3 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Unship unscopables and disable array.values iterators This reverts https://code.google.com/p/v8/source/detail?r=22994 and disables the otherwise web-breaking .values iterator method on arrays and typed arrays. BUG=v8:3401 LOG=Y

Patch Set 1 #

Patch Set 2 : Adjust BUILD.gn #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -700 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/array.js	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/array-iterator.js	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/bootstrapper.cc	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	src/contexts.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/flag-definitions.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/symbol.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	src/unscopables.js	View		1 chunk	+39 lines, -0 lines	0 comments	Download
M	test/cctest/test-unscopables-hidden-prototype.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/es6/array-iterator.js	View		6 chunks	+17 lines, -10 lines	0 comments	Download
M	test/mjsunit/es6/symbols.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/es6/typed-array-iterator.js	View		1 chunk	+8 lines, -4 lines	0 comments	Download
D	test/mjsunit/es6/unscopables.js	View		1 chunk	+0 lines, -664 lines	0 comments	Download
A +	test/mjsunit/harmony/unscopables.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/generate-runtime-tests.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View		3 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

Jochen, use this CL to revert unscopables, in case problems show up while I'm gone.

6 years, 4 months ago (2014-08-08 12:25:26 UTC) #1

arv (Not doing code reviews)

On 2014/08/08 at 12:25:26, rossberg wrote: > Jochen, use this CL to revert unscopables, in ...

6 years, 4 months ago (2014-08-08 15:42:01 UTC) #2

jochen (gone - plz use gerrit)

6 years, 3 months ago (2014-09-01 08:51:47 UTC) #3

We branched after your changes, so we don't need this CL anymore. Thanks anyway
for preparing it.

Expand Messages | Collapse Messages