Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: test/mjsunit/es6/array-iterator.js

Issue 455763002: Unship unscopables and disable array.values iterators (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Adjust BUILD.gn Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-unscopables-hidden-prototype.cc ('k') | test/mjsunit/es6/symbols.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/array-iterator.js
diff --git a/test/mjsunit/es6/array-iterator.js b/test/mjsunit/es6/array-iterator.js
index 63a7415b966f9bbe9fbdc5266fc5b5c4447238ff..d3e49842928176457df69b3e306ea26d09d53dbd 100644
--- a/test/mjsunit/es6/array-iterator.js
+++ b/test/mjsunit/es6/array-iterator.js
@@ -45,11 +45,13 @@ function assertHasOwnProperty(object, name, attrs) {
function TestArrayPrototype() {
assertHasOwnProperty(Array.prototype, 'entries', DONT_ENUM);
- assertHasOwnProperty(Array.prototype, 'values', DONT_ENUM);
+ // TODO(arv): Reenable once @@unscopables are shipping.
+ // assertHasOwnProperty(Array.prototype, 'values', DONT_ENUM);
assertHasOwnProperty(Array.prototype, 'keys', DONT_ENUM);
assertHasOwnProperty(Array.prototype, Symbol.iterator, DONT_ENUM);
- assertEquals(Array.prototype.values, Array.prototype[Symbol.iterator]);
+ // TODO(arv): Reenable once @@unscopables are shipping.
+ // assertEquals(Array.prototype.values, Array.prototype[Symbol.iterator]);
}
TestArrayPrototype();
@@ -70,7 +72,8 @@ function TestValues() {
array.push('d');
assertIteratorResult(void 0, true, iterator.next());
}
-TestValues();
+// TODO(arv): Reenable once @@unscopables are shipping.
+// TestValues();
function TestValuesMutate() {
@@ -83,7 +86,8 @@ function TestValuesMutate() {
assertIteratorResult('d', false, iterator.next());
assertIteratorResult(void 0, true, iterator.next());
}
-TestValuesMutate();
+// TODO(arv): Reenable once @@unscopables are shipping.
+// TestValuesMutate();
function TestKeys() {
@@ -142,17 +146,19 @@ TestEntriesMutate();
function TestArrayIteratorPrototype() {
var array = [];
- var iterator = array.values();
+ var iterator = array.entries();
var ArrayIteratorPrototype = iterator.__proto__;
- assertEquals(ArrayIteratorPrototype, array.values().__proto__);
+ // TODO(arv): Reenable once @@unscopables are shipping.
+ // assertEquals(ArrayIteratorPrototype, array.values().__proto__);
assertEquals(ArrayIteratorPrototype, array.keys().__proto__);
assertEquals(ArrayIteratorPrototype, array.entries().__proto__);
assertEquals(Object.prototype, ArrayIteratorPrototype.__proto__);
- assertEquals('Array Iterator', %_ClassOf(array.values()));
+ // TODO(arv): Reenable once @@unscopables are shipping.
+ // assertEquals('Array Iterator', %_ClassOf(array.values()));
assertEquals('Array Iterator', %_ClassOf(array.keys()));
assertEquals('Array Iterator', %_ClassOf(array.entries()));
@@ -180,7 +186,8 @@ function TestForArrayValues() {
}
assertTrue(isNaN(buffer[buffer.length - 1]));
}
-TestForArrayValues();
+// TODO(arv): Reenable once @@unscopables are shipping.
+// TestForArrayValues();
function TestForArrayKeys() {
@@ -237,12 +244,12 @@ function TestForArray() {
}
assertTrue(isNaN(buffer[buffer.length - 1]));
}
-TestForArrayValues();
+TestForArray();
function TestNonOwnSlots() {
var array = [0];
- var iterator = array.values();
+ var iterator = array.entries();
var object = {__proto__: iterator};
assertThrows(function() {
« no previous file with comments | « test/cctest/test-unscopables-hidden-prototype.cc ('k') | test/mjsunit/es6/symbols.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698