Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: src/array-iterator.js

Issue 455763002: Unship unscopables and disable array.values iterators (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Adjust BUILD.gn Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/array.js ('k') | src/bootstrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/array-iterator.js
diff --git a/src/array-iterator.js b/src/array-iterator.js
index f04d6c974a4d41ea27347afde466ec1166e38d31..61a6785c1bbfe29ddf714050f2cf5fe029fca2dd 100644
--- a/src/array-iterator.js
+++ b/src/array-iterator.js
@@ -121,7 +121,8 @@ function ExtendArrayPrototype() {
InstallFunctions($Array.prototype, DONT_ENUM, $Array(
'entries', ArrayEntries,
- 'values', ArrayValues,
+ // TODO(arv): Reenable once @@unscopables are shipping.
+ // 'values', ArrayValues,
'keys', ArrayKeys
));
@@ -147,7 +148,8 @@ endmacro
macro EXTEND_TYPED_ARRAY(NAME)
%AddNamedProperty($NAME.prototype, 'entries', ArrayEntries, DONT_ENUM);
- %AddNamedProperty($NAME.prototype, 'values', ArrayValues, DONT_ENUM);
+ // TODO(arv): Reenable once @@unscopables are shipping.
+ // %AddNamedProperty($NAME.prototype, 'values', ArrayValues, DONT_ENUM);
%AddNamedProperty($NAME.prototype, 'keys', ArrayKeys, DONT_ENUM);
%AddNamedProperty($NAME.prototype, symbolIterator, ArrayValues, DONT_ENUM);
endmacro
« no previous file with comments | « src/array.js ('k') | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698