Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 454053005: Consolidate ExtensionToolbarModel::Action and LocationBarController::Action (Closed)

Created:
6 years, 4 months ago by Devlin
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Consolidate ExtensionToolbarModel::Action and LocationBarController::Action BUG=403083 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289654

Patch Set 1 : #

Patch Set 2 : Latest master for CQ #

Messages

Total messages: 11 (0 generated)
Devlin
Fairly straight-forward cleanup; please take a look when you can. avi@ - c/b/ui/cocoa finnur@ - ...
6 years, 4 months ago (2014-08-12 22:55:35 UTC) #1
Avi (use Gerrit)
Cocoa stuff LGTM
6 years, 4 months ago (2014-08-12 23:21:13 UTC) #2
Finnur
LGTM
6 years, 4 months ago (2014-08-13 11:03:43 UTC) #3
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-13 17:11:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/454053005/100001
6 years, 4 months ago (2014-08-13 17:13:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 23:18:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 11:51:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/5634)
6 years, 4 months ago (2014-08-14 11:51:48 UTC) #8
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-14 14:07:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/454053005/100001
6 years, 4 months ago (2014-08-14 14:11:05 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 18:50:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (100001) as 289654

Powered by Google App Engine
This is Rietveld 408576698