Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: chrome/browser/extensions/active_script_controller.cc

Issue 454053005: Consolidate ExtensionToolbarModel::Action and LocationBarController::Action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master for CQ Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/active_script_controller.h" 5 #include "chrome/browser/extensions/active_script_controller.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
11 #include "base/stl_util.h" 11 #include "base/stl_util.h"
12 #include "chrome/browser/extensions/active_tab_permission_granter.h" 12 #include "chrome/browser/extensions/active_tab_permission_granter.h"
13 #include "chrome/browser/extensions/extension_action.h" 13 #include "chrome/browser/extensions/extension_action.h"
14 #include "chrome/browser/extensions/extension_action_manager.h" 14 #include "chrome/browser/extensions/extension_action_manager.h"
15 #include "chrome/browser/extensions/extension_util.h" 15 #include "chrome/browser/extensions/extension_util.h"
16 #include "chrome/browser/extensions/location_bar_controller.h"
17 #include "chrome/browser/extensions/tab_helper.h" 16 #include "chrome/browser/extensions/tab_helper.h"
18 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
19 #include "chrome/browser/sessions/session_id.h" 18 #include "chrome/browser/sessions/session_id.h"
20 #include "chrome/common/extensions/api/extension_action/action_info.h" 19 #include "chrome/common/extensions/api/extension_action/action_info.h"
21 #include "content/public/browser/navigation_controller.h" 20 #include "content/public/browser/navigation_controller.h"
22 #include "content/public/browser/navigation_entry.h" 21 #include "content/public/browser/navigation_entry.h"
23 #include "content/public/browser/render_view_host.h" 22 #include "content/public/browser/render_view_host.h"
24 #include "content/public/browser/web_contents.h" 23 #include "content/public/browser/web_contents.h"
25 #include "extensions/browser/extension_registry.h" 24 #include "extensions/browser/extension_registry.h"
26 #include "extensions/common/extension.h" 25 #include "extensions/common/extension.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 113
115 linked_ptr<ExtensionAction> action(ExtensionActionManager::Get( 114 linked_ptr<ExtensionAction> action(ExtensionActionManager::Get(
116 Profile::FromBrowserContext(web_contents()->GetBrowserContext())) 115 Profile::FromBrowserContext(web_contents()->GetBrowserContext()))
117 ->GetBestFitAction(*extension, ActionInfo::TYPE_PAGE).release()); 116 ->GetBestFitAction(*extension, ActionInfo::TYPE_PAGE).release());
118 action->SetIsVisible(ExtensionAction::kDefaultTabId, true); 117 action->SetIsVisible(ExtensionAction::kDefaultTabId, true);
119 118
120 active_script_actions_[extension->id()] = action; 119 active_script_actions_[extension->id()] = action;
121 return action.get(); 120 return action.get();
122 } 121 }
123 122
124 LocationBarController::Action ActiveScriptController::OnClicked( 123 ExtensionAction::ShowAction ActiveScriptController::OnClicked(
125 const Extension* extension) { 124 const Extension* extension) {
126 DCHECK(ContainsKey(pending_requests_, extension->id())); 125 DCHECK(ContainsKey(pending_requests_, extension->id()));
127 RunPendingForExtension(extension); 126 RunPendingForExtension(extension);
128 return LocationBarController::ACTION_NONE; 127 return ExtensionAction::ACTION_NONE;
129 } 128 }
130 129
131 void ActiveScriptController::OnNavigated() { 130 void ActiveScriptController::OnNavigated() {
132 LogUMA(); 131 LogUMA();
133 permitted_extensions_.clear(); 132 permitted_extensions_.clear();
134 pending_requests_.clear(); 133 pending_requests_.clear();
135 } 134 }
136 135
137 void ActiveScriptController::OnExtensionUnloaded(const Extension* extension) { 136 void ActiveScriptController::OnExtensionUnloaded(const Extension* extension) {
138 PendingRequestMap::iterator iter = pending_requests_.find(extension->id()); 137 PendingRequestMap::iterator iter = pending_requests_.find(extension->id());
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 UMA_HISTOGRAM_COUNTS_100( 305 UMA_HISTOGRAM_COUNTS_100(
307 "Extensions.ActiveScriptController.PermittedExtensions", 306 "Extensions.ActiveScriptController.PermittedExtensions",
308 permitted_extensions_.size()); 307 permitted_extensions_.size());
309 UMA_HISTOGRAM_COUNTS_100( 308 UMA_HISTOGRAM_COUNTS_100(
310 "Extensions.ActiveScriptController.DeniedExtensions", 309 "Extensions.ActiveScriptController.DeniedExtensions",
311 pending_requests_.size()); 310 pending_requests_.size());
312 } 311 }
313 } 312 }
314 313
315 } // namespace extensions 314 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/active_script_controller.h ('k') | chrome/browser/extensions/extension_action.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698