chrome/browser/extensions/page_action_controller.h - Issue 454053005: Consolidate ExtensionToolbarModel::Action and LocationBarController::Action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/page_action_controller.h

Issue 454053005: Consolidate ExtensionToolbarModel::Action and LocationBarController::Action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master for CQ Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/page_action_controller.h

diff --git a/chrome/browser/extensions/page_action_controller.h b/chrome/browser/extensions/page_action_controller.h

index 179fd28bea77be617fe5d422a137cbd9ce1c32d8..763da32090928b7ddc50d79c92ce2e21fe6c31bb 100644

--- a/chrome/browser/extensions/page_action_controller.h

+++ b/chrome/browser/extensions/page_action_controller.h

@@ -25,7 +25,7 @@ class PageActionController : public LocationBarController::ActionProvider {

// LocationBarController::Provider implementation.

virtual ExtensionAction* GetActionForExtension(const Extension* extension)

OVERRIDE;

- virtual LocationBarController::Action OnClicked(

+ virtual ExtensionAction::ShowAction OnClicked(

const Extension* extension) OVERRIDE;

virtual void OnNavigated() OVERRIDE;

« no previous file with comments | « chrome/browser/extensions/location_bar_controller.cc ('k') | chrome/browser/extensions/page_action_controller.cc » ('j') | no next file with comments »