Issue 453813003: Remove the needsSiteSpecificQuirks setting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453813003: Remove the needsSiteSpecificQuirks setting (Closed)

Created:
6 years, 4 months ago by philipj_slow

Modified:
6 years, 4 months ago

Reviewers:
eseidel, abarth-chromium

CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove the needsSiteSpecificQuirks setting It does nothing as of Blink r178756: https://codereview.chromium.org/414443006 It's never set as of Chromium r289294: https://codereview.chromium.org/449393002 BUG=401887 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180193

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
M	Source/core/frame/Settings.in	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebSettingsImpl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebSettingsImpl.cpp	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	public/web/WebSettings.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/453813003/20001

6 years, 4 months ago (2014-08-13 16:34:11 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (20001) as 180193

6 years, 4 months ago (2014-08-13 16:52:42 UTC) #6

jbroman

6 years, 4 months ago (2014-08-13 17:00:24 UTC) #7

Message was sent while issue was closed.

On 2014/08/13 16:52:42, I haz the power (commit-bot) wrote:
> Committed patchset #2 (20001) as 180193

Woohoo! I meant to go back and remove this, but apparently didn't get around to
it. Great to see this gone.

Expand Messages | Collapse Messages