Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 414443006: Remove QuickTime classid quirk. (Closed)

Created:
6 years, 5 months ago by jbroman
Modified:
6 years, 5 months ago
Reviewers:
jamesr, esprehn, eseidel
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove QuickTime classid quirk. This is a non-standard site-specific quirk for Mac OS X Wiki Server. And NPAPI is going away soon anyway. This was added three years ago in WebKit: https://bugs.webkit.org/show_bug.cgi?id=61229 BUG=396290 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M Source/core/html/HTMLObjectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbroman
If you'd prefer, I can instead put in a UseCounter, or we can just wait ...
6 years, 5 months ago (2014-07-22 23:12:27 UTC) #1
eseidel
lgtm
6 years, 5 months ago (2014-07-22 23:13:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/414443006/1
6 years, 5 months ago (2014-07-22 23:16:13 UTC) #3
jbroman
On 2014/07/22 23:13:48, eseidel wrote: > lgtm Worthwhile to remove the needsSiteSpecificQuirks setting and flag ...
6 years, 5 months ago (2014-07-22 23:17:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 01:06:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 02:58:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31129)
6 years, 5 months ago (2014-07-23 02:58:55 UTC) #7
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 5 months ago (2014-07-23 13:34:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/414443006/1
6 years, 5 months ago (2014-07-23 13:34:45 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 13:35:34 UTC) #10
Message was sent while issue was closed.
Change committed as 178756

Powered by Google App Engine
This is Rietveld 408576698