Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 449393002: Stop using the needsSiteSpecificQuirks setting (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
jam, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Stop using the needsSiteSpecificQuirks setting It does nothing as of Blink r178756: https://codereview.chromium.org/414443006 BUG=401887 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289294

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/web_preferences.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-08 07:50:20 UTC) #1
philipj_slow
To be followed by https://codereview.chromium.org/453813003/
6 years, 4 months ago (2014-08-08 07:50:40 UTC) #2
philipj_slow
jam@, can you PTAL?
6 years, 4 months ago (2014-08-11 22:36:04 UTC) #3
jam
lgtm
6 years, 4 months ago (2014-08-12 23:54:12 UTC) #4
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-13 05:29:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/449393002/1
6 years, 4 months ago (2014-08-13 05:30:07 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 05:36:02 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 05:38:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3865) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/5709) win8_chromium_rel ...
6 years, 4 months ago (2014-08-13 05:39:00 UTC) #9
philipj_slow
rebase
6 years, 4 months ago (2014-08-13 07:15:29 UTC) #10
philipj_slow
nasko, can you please review content/public/common/common_param_traits_macros.h?
6 years, 4 months ago (2014-08-13 07:22:02 UTC) #11
nasko
LGTM
6 years, 4 months ago (2014-08-13 14:17:52 UTC) #12
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-13 14:18:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/449393002/20001
6 years, 4 months ago (2014-08-13 14:19:34 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 15:13:04 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 289294

Powered by Google App Engine
This is Rietveld 408576698