Issue 453613003: mark all SkImage methods const, so we can make it thread-safe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453613003: mark all SkImage methods const, so we can make it thread-safe (Closed)

Created:
6 years, 4 months ago by reed1

Modified:
6 years, 4 months ago

Reviewers:
hal.canary, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

mark all SkImage methods const, so we can make it thread-safe BUG=skia: Committed: https://skia.googlesource.com/skia/+/8572fc01ac4f6bdcf173b05417776abc55f729c1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -34 lines)			Patch
M	include/core/SkImage.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/image/SkImage.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/image/SkImage_Base.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/image/SkImage_Codec.cpp	View	2 chunks	+12 lines, -7 lines	0 comments	Download
M	src/image/SkImage_Gpu.cpp	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/image/SkImage_Raster.cpp	View	3 chunks	+9 lines, -11 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/453613003/1

6 years, 4 months ago (2014-08-11 19:55:18 UTC) #3

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

6 years, 4 months ago (2014-08-11 19:55:19 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-11 20:04:00 UTC) #6

Message was sent while issue was closed.

Change committed as 8572fc01ac4f6bdcf173b05417776abc55f729c1