Chromium Code Reviews| Index: components/copresence/mediums/audio/audio_recorder_unittest.cc |
| diff --git a/components/copresence/mediums/audio/audio_recorder_unittest.cc b/components/copresence/mediums/audio/audio_recorder_unittest.cc |
| index 900dffbc8a16fbcec415d7bafe6a0472d777da6c..69c856aa717aebdf77ae74c2f9e7c3338ee026b2 100644 |
| --- a/components/copresence/mediums/audio/audio_recorder_unittest.cc |
| +++ b/components/copresence/mediums/audio/audio_recorder_unittest.cc |
| @@ -189,18 +189,14 @@ class AudioRecorderTest : public testing::Test { |
| content::TestBrowserThreadBundle thread_bundle_; |
| }; |
| -#if defined(OS_WIN) || defined(OS_MACOSX) |
| -// Windows does not let us use non-OS params. The tests need to be rewritten to |
| -// use the params provided to us by the audio manager rather than setting our |
| -// own params. |
| +// TODO(rkc): These tests are broken on all platforms. |
|
rkc
2014/08/09 19:20:37
I looked at that bot again. It isn't a fail, it is
Charlie
2014/08/11 16:10:18
This test is breaking the Linux valgrind bot:
htt
|
| +// On Windows and Mac, we cannot use non-OS params. The tests need to be |
| +// rewritten to use the params provided to us by the audio manager |
| +// rather than setting our own params. |
| +// On Linux, there is a memory leak in the audio code during initialization. |
| #define MAYBE_BasicRecordAndStop DISABLED_BasicRecordAndStop |
| #define MAYBE_OutOfOrderRecordAndStopMultiple DISABLED_OutOfOrderRecordAndStopMultiple |
| #define MAYBE_RecordingEndToEnd DISABLED_RecordingEndToEnd |
| -#else |
| -#define MAYBE_BasicRecordAndStop BasicRecordAndStop |
| -#define MAYBE_OutOfOrderRecordAndStopMultiple OutOfOrderRecordAndStopMultiple |
| -#define MAYBE_RecordingEndToEnd RecordingEndToEnd |
| -#endif |
| TEST_F(AudioRecorderTest, MAYBE_BasicRecordAndStop) { |
| CreateSimpleRecorder(); |