Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: components/copresence/handlers/audio/audio_directive_list_unittest.cc

Issue 453203002: Fixing memory leak in TimedMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabling broken test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/handlers/audio/audio_directive_list_unittest.cc
diff --git a/components/copresence/handlers/audio/audio_directive_list_unittest.cc b/components/copresence/handlers/audio/audio_directive_list_unittest.cc
index 78d29857e8de71efd2d42e42480ebcc3dbdda263..69574254801cc1ea28603c9e2dfb21d92730024f 100644
--- a/components/copresence/handlers/audio/audio_directive_list_unittest.cc
+++ b/components/copresence/handlers/audio/audio_directive_list_unittest.cc
@@ -35,8 +35,14 @@ class AudioDirectiveListTest : public testing::Test {
scoped_ptr<AudioDirectiveList> directive_list_;
};
-// TODO(rkc): Find and fix the memory leak here.
+// TODO(rkc): Fix these tests on Windows.
+#if defined(OS_WIN)
#define MAYBE_Basic DISABLED_Basic
+#define MAYBE_OutOfOrderAndMultiple DISABLED_OutOfOrderAndMultiple
+#else
+#define MAYBE_Basic Basic
+#define MAYBE_OutOfOrderAndMultiple OutOfOrderAndMultiple
+#endif
TEST_F(AudioDirectiveListTest, MAYBE_Basic) {
const base::TimeDelta kZeroTtl = base::TimeDelta::FromMilliseconds(0);
@@ -56,9 +62,6 @@ TEST_F(AudioDirectiveListTest, MAYBE_Basic) {
EXPECT_EQ("op_id3", directive_list_->GetNextReceive()->op_id);
}
-// TODO(rkc): Find out why this is breaking on bots and fix it.
-#define MAYBE_OutOfOrderAndMultiple DISABLED_OutOfOrderAndMultiple
-
TEST_F(AudioDirectiveListTest, MAYBE_OutOfOrderAndMultiple) {
const base::TimeDelta kZeroTtl = base::TimeDelta::FromMilliseconds(0);
const base::TimeDelta kLargeTtl = base::TimeDelta::FromSeconds(0x7331);

Powered by Google App Engine
This is Rietveld 408576698