Fixing memory leak in TimedMap

components/copresence/mediums/audio/audio_recorder_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/copresence/mediums/audio/audio_recorder.h"
 
 #include "base/bind.h"
 #include "base/memory/aligned_memory.h"
 #include "base/run_loop.h"
 #include "components/copresence/public/copresence_constants.h"
@@ skipping 171 matching lines @@
   size_t total_samples_;
 
   AudioRecorder* recorder_;
 
   std::string received_samples_;
 
   scoped_ptr<base::RunLoop> run_loop_;
   content::TestBrowserThreadBundle thread_bundle_;
 };
 
-#if defined(OS_WIN) || defined(OS_MACOSX)
-// Windows does not let us use non-OS params. The tests need to be rewritten to
-// use the params provided to us by the audio manager rather than setting our
-// own params.
+// TODO(rkc): These tests are broken on all platforms.

[rkc, 2014/08/09 19:20:37]

I looked at that bot again. It isn't a fail, it is a suppression. Please
re-enable this test for other platforms.

[Charlie, 2014/08/11 16:10:18]

This test is breaking the Linux valgrind bot:

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...

+// On Windows and Mac, we cannot use non-OS params. The tests need to be
+// rewritten to use the params provided to us by the audio manager
+// rather than setting our own params.
+// On Linux, there is a memory leak in the audio code during initialization.
 #define MAYBE_BasicRecordAndStop DISABLED_BasicRecordAndStop
 #define MAYBE_OutOfOrderRecordAndStopMultiple DISABLED_OutOfOrderRecordAndStopMultiple
 #define MAYBE_RecordingEndToEnd DISABLED_RecordingEndToEnd
-#else
-#define MAYBE_BasicRecordAndStop BasicRecordAndStop
-#define MAYBE_OutOfOrderRecordAndStopMultiple OutOfOrderRecordAndStopMultiple
-#define MAYBE_RecordingEndToEnd RecordingEndToEnd
-#endif
 
 TEST_F(AudioRecorderTest, MAYBE_BasicRecordAndStop) {
   CreateSimpleRecorder();
 
   recorder_->Record();
   EXPECT_TRUE(IsRecording());
   recorder_->Stop();
   EXPECT_FALSE(IsRecording());
   recorder_->Record();
 
@@ skipping 34 matching lines @@
       kDefaultChannels, kDefaultSampleRate, kDefaultBitsPerSample, kNumSamples);
 
   RecordAndVerifySamples();
 
   DeleteRecorder();
 }
 
 // TODO(rkc): Add tests with recording different sample rates.
 
 }  // namespace copresence