components/copresence/handlers/audio/audio_directive_handler_unittest.cc - Issue 453203002: Fixing memory leak in TimedMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/copresence/handlers/audio/audio_directive_handler_unittest.cc

Issue 453203002: Fixing memory leak in TimedMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabling broken test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/copresence/handlers/audio/audio_directive_list_unittest.cc » ('j') | components/copresence/mediums/audio/audio_recorder_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/copresence/handlers/audio/audio_directive_handler_unittest.cc

diff --git a/components/copresence/handlers/audio/audio_directive_handler_unittest.cc b/components/copresence/handlers/audio/audio_directive_handler_unittest.cc

index 5332252f3d6eda1324d988315f17c3555b516058..5bee44a7418fe21ce87605bb1e8ba20cf053fe72 100644

--- a/components/copresence/handlers/audio/audio_directive_handler_unittest.cc

+++ b/components/copresence/handlers/audio/audio_directive_handler_unittest.cc

@@ -76,10 +76,8 @@ class AudioDirectiveHandlerTest : public testing::Test {

DISALLOW_COPY_AND_ASSIGN(AudioDirectiveHandlerTest);

};

-// TODO(rkc): Find and fix the memory leak here.

-#define MAYBE_Basic DISABLED_Basic

-TEST_F(AudioDirectiveHandlerTest, MAYBE_Basic) {

+// TODO(rkc): This test is broken, possibly due to the changes for audible.

+TEST_F(AudioDirectiveHandlerTest, DISABLED_Basic) {

const base::TimeDelta kSmallTtl = base::TimeDelta::FromMilliseconds(0x1337);

const base::TimeDelta kLargeTtl = base::TimeDelta::FromSeconds(0x7331);